ref(logs): allow different log level types #1992
Conversation
| } | ||
|
|
||
| public static function logLevelDataProvider(): iterable | ||
| public static function monologLegacyLevelDataProvider(): iterable |
There was a problem hiding this comment.
The tests are maybe a bit too verbose and confusing, not sure
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return $record['level'] >= $this->logLevel->value; | ||
| } else { | ||
| return $record['level'] >= $this->logLevel; | ||
| } |
There was a problem hiding this comment.
Enum-to-int comparison fails in Monolog 3
High Severity
In Monolog 3, $record['level'] returns a \Monolog\Level enum object, not an integer. The comparisons on lines 59 and 61 attempt to compare this enum directly with integer values ($this->logLevel->value or $this->logLevel), which throws a TypeError in PHP 8.1+ since backed enums cannot be compared with integers using >=. The BreadcrumbHandler in the same codebase demonstrates the correct pattern: checking if ($level instanceof Level) and extracting $level->value before comparison.
There was a problem hiding this comment.
The analysis seems to be incorrect: https://github.com/Seldaek/monolog/blob/main/src/Monolog/LogRecord.php#L86
level is returning $this->level->value, which is the integer defined in the enum
This PR extends the possible log level to properly handle the filtering of log messages.
Since sentry has fewer log levels than monolog, it wasn't possible to filter based on monolog levels because we would convert it losing some levels. With the changes in this PR, it will be possible to filter based on monolog levels and the severity will only be converted when sending to sentry.