-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using types-WebOb
#2226
Labels
Enhancement
New feature or request
Comments
antonpirker
added
Status: Backlog
and removed
Status: Untriaged
Waiting for: Product Owner
labels
Jul 5, 2023
Hey @Daverball Thanks for writing in, sounds like a good think. (In general for our typing there is still lots of room for improvement.) |
Hi @Daverball, if you would like to implement this, feel free to submit a PR. We are closing for now since we do not plan to implement this ourselves |
Daverball
added a commit
to Daverball/sentry-python
that referenced
this issue
Jun 3, 2024
Adds `types-webob`, `types-greenlet` and `types-gevent` to linter requirements and fixes newly exposed typing issues. Fixes getsentryGH-2226
Daverball
added a commit
to Daverball/sentry-python
that referenced
this issue
Jun 4, 2024
Adds `types-webob`, `types-greenlet` and `types-gevent` to linter requirements and fixes newly exposed typing issues. Fixes getsentryGH-2226
Daverball
added a commit
to Daverball/sentry-python
that referenced
this issue
Jun 6, 2024
Adds `types-webob`, `types-greenlet` and `types-gevent` to linter requirements and fixes newly exposed typing issues. Fixes getsentryGH-2226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Statement
I've recently contributed type stubs for WebOb on typeshed, which have been merged and are now available to the public. Some of the Integrations refer to types defined in WebOb (e.g.
PyramidIntegration
), but don't yet make use oftypes-WebOb
and as such are really operating onAny
.Solution Brainstorm
Install
types-WebOb
and fix any uncovered typing issues.As a side note, I've noticed that sometimes you use
dict[str, str]
as the type annotation forenviron
, even though that is inaccurate. You should use_typeshed.wsgi.WSGIEnvironment
which is currently an alias fordict[str, Any]
but will ensure that your type hints forenviron
will remain consistent with the stdlib and any third party stubs managed through typeshed in the future.The same goes for
WSGIApplication
andStartResponse
defined within that module.The text was updated successfully, but these errors were encountered: