Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document test_sessions #3429

Open
szokeasaurusrex opened this issue Aug 9, 2024 · 0 comments
Open

Document test_sessions #3429

szokeasaurusrex opened this issue Aug 9, 2024 · 0 comments

Comments

@szokeasaurusrex
Copy link
Member

test_sessions.py is a bit confusing. This was brought up in a recent code review. We should add some comments to clarify what we are trying to test.

Tests are always also a kind of documentation on how to use the code.

Could you add comments to the three sessions to mark what aggregate status is expected for each one of them?

Please add those comments to all similar tests in this file. This will help us in the future (or others) to understand what is going on.

Originally posted by @antonpirker in #3419 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant