Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(django): Add db.system #2040

Merged
merged 17 commits into from
Apr 27, 2023
Merged

feat(django): Add db.system #2040

merged 17 commits into from
Apr 27, 2023

Conversation

AbhiPrasad
Copy link
Member

ref getsentry/team-webplatform-meta#60

So worked out when testing locally + the types seem to enforce this, and it works on all django versions, so I think this is good to go.

@AbhiPrasad AbhiPrasad force-pushed the abhi-db-system-django branch from 5680231 to da0d0c3 Compare April 26, 2023 11:16
@AbhiPrasad
Copy link
Member Author

@antonpirker this is now ready to review - Lint error are unrelated

sentry_sdk/integrations/flask.py:162: error: "ImmutableMultiDict" expects no type arguments, but 2 given  [type-arg]
sentry_sdk/integrations/flask.py:166: error: "ImmutableMultiDict" expects no type arguments, but 2 given  [type-arg]
Found 2 errors in 1 file (checked 91 source files)

https://github.com/getsentry/sentry-python/actions/runs/4809397087/jobs/8560589799?pr=2040

@antonpirker antonpirker self-assigned this Apr 27, 2023
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antonpirker antonpirker merged commit 06381de into master Apr 27, 2023
@antonpirker antonpirker deleted the abhi-db-system-django branch April 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants