Fix: Duration in Celery Beat tasks monitoring #2087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
approved these changes
May 8, 2023
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Found some typos, looks good otherwise 🚀
Co-authored-by: Ivana Kellyerova <131587164+sentrivana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not use a
perf_counterwhen dealing with duration's of Celery tasks, because the start of a Celery tasks and the finish are recorded in different processes.Start happens in the Celery Beat process, the end in the Celery Worker process.
Fixes #2078