Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Cache Module - 2 - Add Cache Spans #3075

Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
557165b
x
antonpirker May 15, 2024
5bc00d0
x
antonpirker May 15, 2024
31c0769
Some work to use same function for queries and caches module
antonpirker May 15, 2024
7a65e5d
Moved functions to better place
antonpirker May 15, 2024
7298402
Added tests
antonpirker May 16, 2024
d3d485b
Fix
antonpirker May 16, 2024
932fcdc
Tests and linting
antonpirker May 17, 2024
3acf6c4
Thats important for Python 3.6
antonpirker May 17, 2024
20ae85c
Fixed some tests
antonpirker May 17, 2024
c10585a
Removed ipdb
antonpirker May 17, 2024
9d12889
more fixing
antonpirker May 17, 2024
bcf3e3e
Cleanup
antonpirker May 17, 2024
0dfefac
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 17, 2024
2a63ac9
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 17, 2024
3231674
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 17, 2024
20f46f8
Async cache spans
antonpirker May 17, 2024
f603fb7
Added async tests
antonpirker May 17, 2024
90f92a6
Fixed async tests
antonpirker May 17, 2024
075ae16
Guard for not running async tests when there is no async fakeredis fo…
antonpirker May 17, 2024
5ceefb3
linting
antonpirker May 17, 2024
998fa9c
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 17, 2024
9d0c536
Use new names for ops
antonpirker May 21, 2024
2ca208d
Renamed for consistency
antonpirker May 21, 2024
b789c92
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 21, 2024
e0f58af
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 21, 2024
ddf4962
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 22, 2024
aabda8b
fix _get_op()
antonpirker May 22, 2024
c5bcd75
Cleaning up unused properties/parameters
antonpirker May 22, 2024
db54981
Use _get_safe_key in Django integration
antonpirker May 22, 2024
1dded72
Fixed typing
antonpirker May 22, 2024
16aec47
More tests
antonpirker May 22, 2024
f9eb6ce
Only return the keys in set_many, makes more sense
antonpirker May 22, 2024
10d353c
Linting
antonpirker May 22, 2024
671763b
Cleanup
antonpirker May 22, 2024
38c14e9
fix(clickhouse): `_sentry_span` might be missing (#3096)
sentrivana May 22, 2024
7a0217b
Make _get_safe_key work for all multi key methods in django and redis
antonpirker May 22, 2024
e1db1f5
Fixed kwargs case and updated tests
antonpirker May 22, 2024
0024f81
Updated tests
antonpirker May 23, 2024
7e275eb
cache.set should be cache.put
antonpirker May 23, 2024
ec23396
Fix `cohere` testsuite for new release of `cohere`. (#3098)
antonpirker May 23, 2024
941ca77
Merge branch 'master' into antonpirker/django-caching-module
antonpirker May 23, 2024
80f50d5
Merge branch 'antonpirker/django-caching-module' into antonpirker/red…
antonpirker May 23, 2024
24d96f9
Merge branch 'antonpirker/redis-cache-module-1' into antonpirker/redi…
antonpirker May 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed typing
antonpirker committed May 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 1dded727c19aeef3956df03b629bf18812ee39e2
4 changes: 2 additions & 2 deletions sentry_sdk/integrations/redis/utils.py
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@


if TYPE_CHECKING:
from typing import Any, Sequence
from typing import Any, Optional, Sequence
from sentry_sdk.tracing import Span


@@ -45,7 +45,7 @@ def _get_safe_command(name, args):


def _get_safe_key(args, kwargs):
# type: (tuple[Any, ...], dict[str, Any]) -> str
# type: (Optional[tuple[Any, ...]], Optional[dict[str, Any]]) -> str
key = ""

if args is not None and len(args) >= 1: