Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(otel): Remove autoinstrumentation #3239

Merged
merged 16 commits into from
Jul 30, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 3, 2024

Removing experimental OTel autoinstrumentation since we want to focus on getting basic OTel support right. Once we're confident that our instrumentation works correctly with OTel, we can focus on adding OTel integration packages.

We can reuse some stuff this PR removes then, if necessary.

I've kept the basic skeleton and an example with Django for later to have it in place once we start enabling integrations one by one.

Closes #3238

@sentrivana sentrivana changed the title ref(otel): Remove distro ref(otel): Remove autoinstrumentation Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (6bb2081) to head (08df6aa).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   79.76%   79.72%   -0.05%     
==========================================
  Files         133      132       -1     
  Lines       14313    14237      -76     
  Branches     3012     2997      -15     
==========================================
- Hits        11417    11350      -67     
+ Misses       2074     2065       -9     
  Partials      822      822              
Files Coverage Δ
...ntry_sdk/integrations/opentelemetry/integration.py 63.33% <65.00%> (-13.48%) ⬇️

... and 3 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review July 19, 2024 11:18
@sl0thentr0py
Copy link
Member

didn't we want to keep the distro setup for later?

@sentrivana
Copy link
Contributor Author

didn't we want to keep the distro setup for later?

The distro setup mostly makes sense if we're using OTel's autodiscovery of instrumentation packages. But since we now want to enable integrations one by one explicitly, we can get rid of the distro stuff. (It also wasn't a "real" distro in the sense of how it should be used. So all in all better to get rid of it to not confuse people.)

@sentrivana sentrivana merged commit fc5db4f into master Jul 30, 2024
123 of 124 checks passed
@sentrivana sentrivana deleted the ivana/potel/turn-off-autoinstrumentation branch July 30, 2024 11:12
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable POTel autoinstrumentation
2 participants