test(client): Avoid configure_scope
#3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## szokeasaurusrex/configure-scope-1 #3350 +/- ##
=====================================================================
+ Coverage 79.64% 79.78% +0.13%
=====================================================================
Files 133 133
Lines 14319 14319
Branches 3009 3009
=====================================================================
+ Hits 11404 11424 +20
+ Misses 2093 2071 -22
- Partials 822 824 +2 |
sentrivana
approved these changes
Jul 26, 2024
sl0thentr0py
approved these changes
Jul 26, 2024
Replace the only `configure_scope` usage in `test_client.py`, which can be replaced without defeating the test's purpose, with `Scope.get_isolation_scope`. The other `configure_scope` calls are made either from a test which specifically tests `configure_scope` or from a test which is always skipped. Closes: #3344
szokeasaurusrex
force-pushed
the
szokeasaurusrex/configure-scope-1
branch
from
682f07a to
132a9c5
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/configure-scope-2
branch
from
4aa4c01 to
1d17d57
Compare
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Replace the only `configure_scope` usage in `test_client.py`, which can be replaced without defeating the test's purpose, with `Scope.get_isolation_scope`. The other `configure_scope` calls are made either from a test which specifically tests `configure_scope` or from a test which is always skipped. Closes: getsentry#3344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the only
configure_scopeusage intest_client.py, whichcan be replaced without defeating the test's purpose, with
Scope.get_isolation_scope. The otherconfigure_scopecalls aremade either from a test which specifically tests
configure_scopeor from a test which is always skipped.
Closes: #3344