Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with newer Falcon version #3653

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Test with newer Falcon version #3653

merged 1 commit into from
Oct 14, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Oct 14, 2024

4.0.0b4 is now available.

Copy link

codecov bot commented Oct 14, 2024

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
13492 10 13482 4096
View the top 3 failed tests by shortest run time
tests.integrations.grpc.test_grpc test_grpc_server_other_interceptors
Stack Traces | 0.166s run time
.../integrations/grpc/test_grpc.py:79: in test_grpc_server_other_interceptors
    server = _set_up(interceptors=[mock_interceptor])
.../integrations/grpc/test_grpc.py:33: in _set_up
    server.add_insecure_port("[::]:{}".format(PORT))
.tox/py3.10-grpc-v1.49/lib/python3.10.../site-packages/grpc/_server.py:969: in add_insecure_port
    return _common.validate_port_binding_result(
.tox/py3.10-grpc-v1.49/lib/python3.10.../site-packages/grpc/_common.py:166: in validate_port_binding_result
    raise RuntimeError(_ERROR_MESSAGE_PORT_BINDING_FAILED % address)
E   RuntimeError: Failed to bind to address [::]:50096; set GRPC_VERBOSITY=debug environment variable to see detailed error message.
tests.integrations.grpc.test_grpc test_grpc_client_other_interceptor
Stack Traces | 0.167s run time
.../integrations/grpc/test_grpc.py:230: in test_grpc_client_other_interceptor
    server = _set_up()
.../integrations/grpc/test_grpc.py:33: in _set_up
    server.add_insecure_port("[::]:{}".format(PORT))
.tox/py3.10-grpc-v1.49/lib/python3.10.../site-packages/grpc/_server.py:969: in add_insecure_port
    return _common.validate_port_binding_result(
.tox/py3.10-grpc-v1.49/lib/python3.10.../site-packages/grpc/_common.py:166: in validate_port_binding_result
    raise RuntimeError(_ERROR_MESSAGE_PORT_BINDING_FAILED % address)
E   RuntimeError: Failed to bind to address [::]:50096; set GRPC_VERBOSITY=debug environment variable to see detailed error message.
tests.integrations.grpc.test_grpc test_grpc_server_starts_transaction
Stack Traces | 0.167s run time
.../integrations/grpc/test_grpc.py:48: in test_grpc_server_starts_transaction
    server = _set_up()
.../integrations/grpc/test_grpc.py:33: in _set_up
    server.add_insecure_port("[::]:{}".format(PORT))
.tox/py3.10-grpc-v1.49/lib/python3.10.../site-packages/grpc/_server.py:969: in add_insecure_port
    return _common.validate_port_binding_result(
.tox/py3.10-grpc-v1.49/lib/python3.10.../site-packages/grpc/_common.py:166: in validate_port_binding_result
    raise RuntimeError(_ERROR_MESSAGE_PORT_BINDING_FAILED % address)
E   RuntimeError: Failed to bind to address [::]:50096; set GRPC_VERBOSITY=debug environment variable to see detailed error message.

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana enabled auto-merge (squash) October 14, 2024 08:24
@@ -431,7 +431,7 @@ deps =
falcon-v2: falcon~=2.0
falcon-v3: falcon~=3.0
# TODO: update to 4.0 stable when out
falcon-v4: falcon==4.0.0b3
falcon-v4: falcon==4.0.0b4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this is needed because falcon-latest excludes pre-release versions? Is there any way we can automatically grab the latest pre-release version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tox just pip installs all the targets, which by default will not install prereleases. There's a flag (--pre I think) to change that behavior. So there probably is a way to do this -- something we can look into

@sentrivana sentrivana merged commit 759d6e9 into master Oct 14, 2024
136 checks passed
@sentrivana sentrivana deleted the ivana/new-falcon-again branch October 14, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants