Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom transaction names in asgi #3664

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

fixes #3663

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-fastapi-tx-name branch from f3734d4 to eb8bb5a Compare October 16, 2024 14:41
Copy link

codecov bot commented Oct 16, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
14853 1 14852 4383
View the full list of 1 ❄️ flaky tests
tests.test_transport test_transport_works[threads-False-br-9-True-close-True]

Flake rate in main: 86.42% (Passed 11 times, Failed 70 times)

Stack Traces | 0.672s run time
tests/test_transport.py:175: in test_transport_works
    assert not err and not out
E   assert (not '--- Logging error ---\nTraceback (most recent call last):\n  File ".../hostedtoolcache/Python/3.6.15.../x64/lib/python3...lhandlers\n    return old_callhandlers(self, record)\nMessage: \'background worker got kill request\'\nArguments: ()\n')

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sl0thentr0py sl0thentr0py enabled auto-merge (squash) October 16, 2024 14:53
@sl0thentr0py sl0thentr0py merged commit f493057 into master Oct 16, 2024
136 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-fastapi-tx-name branch October 16, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom transactions being overwritten by ASGI integration
2 participants