Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Update active thread for asgi #3669

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Oct 17, 2024

Ensure the handling thread is set on the transaction for asgi transactions not just main thread.

@Zylphrex Zylphrex marked this pull request as ready for review October 18, 2024 22:22
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (f5e964f) to head (1d09578).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/quart.py 66.66% 0 Missing and 2 partials ⚠️
sentry_sdk/integrations/fastapi.py 66.66% 0 Missing and 1 partial ⚠️
sentry_sdk/integrations/starlette.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3669      +/-   ##
==========================================
+ Coverage   84.31%   84.34%   +0.02%     
==========================================
  Files         133      133              
  Lines       14241    14257      +16     
  Branches     2400     2405       +5     
==========================================
+ Hits        12008    12025      +17     
+ Misses       1487     1482       -5     
- Partials      746      750       +4     
Files with missing lines Coverage Δ
sentry_sdk/integrations/django/asgi.py 87.73% <100.00%> (+0.35%) ⬆️
sentry_sdk/integrations/django/views.py 91.48% <100.00%> (+0.58%) ⬆️
sentry_sdk/tracing.py 85.18% <100.00%> (+0.06%) ⬆️
sentry_sdk/integrations/fastapi.py 89.15% <66.66%> (-0.85%) ⬇️
sentry_sdk/integrations/starlette.py 84.68% <75.00%> (-0.16%) ⬇️
sentry_sdk/integrations/quart.py 82.35% <66.66%> (+2.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for updating the tests everywhere.

@antonpirker antonpirker merged commit ec88aa9 into master Oct 24, 2024
137 of 139 checks passed
@antonpirker antonpirker deleted the txiao/fix/update-active-thread-for-asgi branch October 24, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants