-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing stack frames #3673
Merged
Merged
Add missing stack frames #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3673 +/- ##
==========================================
+ Coverage 79.94% 79.95% +0.01%
==========================================
Files 137 137
Lines 15421 15437 +16
Branches 2614 2619 +5
==========================================
+ Hits 12328 12343 +15
Misses 2223 2223
- Partials 870 871 +1
|
Merged
6 tasks
asottile-sentry
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
antonpirker
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Dec 6, 2024
…11844) Documentation of two new options that where introduced here: getsentry/sentry-python#3673 --------- Co-authored-by: Liza Mock <liza.mock@sentry.io>
Lms24
pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Dec 13, 2024
…11844) Documentation of two new options that where introduced here: getsentry/sentry-python#3673 --------- Co-authored-by: Liza Mock <liza.mock@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
init()
optionadd_full_stack
(defaultFalse
), when set toTrue
it will add all the missing frames from the beginning of the execution to the stack trace sent to Sentry.Also adds another option
max_stack_frames
(default100
) to limit the number of frames sent. The limitation is only enforced whenadd_full_stack=True
to not change behavior for existing users.Documentation update: getsentry/sentry-docs#11844
Fixes #3646