Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP2Transport): Only enable HTTP2 when DSN is HTTPS #3678

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Oct 21, 2024

No description provided.

@BYK BYK requested a review from sentrivana October 21, 2024 16:23
Comment on lines +773 to +774
"http2": self.parsed_dsn is not None
and self.parsed_dsn.scheme == "https",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the core change. All the rest is refactoring to make this easier to implement.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.31%. Comparing base (336b177) to head (7736211).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/transport.py 85.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3678      +/-   ##
==========================================
- Coverage   84.33%   84.31%   -0.03%     
==========================================
  Files         133      133              
  Lines       14231    14241      +10     
  Branches     2398     2400       +2     
==========================================
+ Hits        12002    12007       +5     
- Misses       1485     1487       +2     
- Partials      744      747       +3     
Files with missing lines Coverage Δ
sentry_sdk/transport.py 84.05% <85.18%> (-0.63%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BYK BYK enabled auto-merge (squash) October 22, 2024 12:37
@BYK BYK merged commit 4839004 into master Oct 22, 2024
136 checks passed
@BYK BYK deleted the byk/fix/http2-only-on-https branch October 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants