fix(http2): Check for h2 existence #3690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
HTTP2Transport
needshttpcore
andh2
and we only checked forhttpcore
. This caused runtime errors and dropping of all events during testing as the test platform hadhttpcore
installed but noth2
. This patch adds both as conditions for the new transport implementation. Ideally, when we switch out the old transport, we'd silently check forh2
existence only and set thehttp2
option accordingly.