Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tornado): Unpin pytest for tornado tests #3714

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

szokeasaurusrex
Copy link
Member

ref #3035

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (000c8e6) to head (f8810f4).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3714      +/-   ##
==========================================
- Coverage   84.29%   84.28%   -0.02%     
==========================================
  Files         133      133              
  Lines       14260    14260              
  Branches     2405     2405              
==========================================
- Hits        12021    12019       -2     
  Misses       1490     1490              
- Partials      749      751       +2     

see 1 file with indirect coverage changes

The Pytest version pin is only needed for `tornado-v6.0` and `tornado-v6.2`. The incompatibility with the latest Pytest versions has been fixed in newer Tornado versions.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/unpin-pytest-tornado branch from 3d0a92c to f8810f4 Compare October 29, 2024 12:35
@szokeasaurusrex szokeasaurusrex merged commit bf40090 into master Oct 29, 2024
136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/unpin-pytest-tornado branch October 29, 2024 12:56
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants