test(gcp): Only run GCP tests when they should #3721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCP tests have been running in our common test suite, including on Python versions other than 3.7 (the only version which supports the GCP integration), even though we have a separate `py3.7-gcp` tox environment for these tests. The tests take a long time, so only executing in the appropriate `tox` environment should speed up CI time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3721 +/- ##
==========================================
- Coverage 79.89% 79.87% -0.02%
==========================================
Files 137 137
Lines 15373 15373
Branches 2609 2609
==========================================
- Hits 12282 12279 -3
- Misses 2221 2223 +2
- Partials 870 871 +1 |
antonpirker
deleted the
szokeasaurusrex/only-run-gcp-tests-when-they-should-run
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP tests have been running in our common test suite, including on Python versions other than 3.7 (the only version which supports the GCP integration), even though we have a separate
py3.7-gcptox environment for these tests. The tests take a long time (approx 1 minute+), so only executing in the appropriatetoxenvironment should speed up CI time.