Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sentry-sdk[pure-eval] installable with pip==24.0 #3757

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Nov 11, 2024

There's an issue with pip==24.0 where extras with an underscore in the name can't be installed, so e.g. pip install sentry-sdk[pure_eval] will claim there is no pure_eval extra.

The issue is fixed in pip>=24.1. Some folks are stuck using older versions though. We can fix it for them by renaming the extra to pure-eval instead, which makes pip install sentry-sdk[pure-eval] work correctly in 24.0 too.

(The underscore version sentry-sdk[pure_eval] will continue to work after this change. Tested with pip and uv.)

Closes #3754

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (200d0cd) to head (a5b8f1b).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3757      +/-   ##
==========================================
+ Coverage   84.37%   84.38%   +0.01%     
==========================================
  Files         136      136              
  Lines       14375    14375              
  Branches     2422     2422              
==========================================
+ Hits        12129    12131       +2     
  Misses       1495     1495              
+ Partials      751      749       -2     

see 2 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this will keep on working if users have a "sentry-python[pure_eval]" in their requirements.txt file, that this is fine with me.

@sentrivana
Copy link
Contributor Author

If this will keep on working if users have a "sentry-python[pure_eval]" in their requirements.txt file, that this is fine with me.

As far as I can tell from my tests and from reading up on it (the info is scarce) it should. In the worst case a revert is trivial.

@sentrivana sentrivana merged commit ec2d929 into master Nov 18, 2024
136 checks passed
@sentrivana sentrivana deleted the ivana/fix-for-pip-24.0 branch November 18, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants