Fix asyncio testing setup #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* default `asyncio_default_fixture_loop_scope` to `function` to get rid of deprecation messages * Change `test_asyncio.py` event loop scopes to `module` to avoid that event loop bleeding into all other tests in the same `session`. * Remove explicit `event_loop`s since `pytest-asyncio` takes care of those
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3832 +/- ##
=======================================
Coverage 79.94% 79.95%
=======================================
Files 137 137
Lines 15421 15421
Branches 2614 2614
=======================================
+ Hits 12329 12330 +1
Misses 2223 2223
+ Partials 869 868 -1 |
antonpirker
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Looks good.
The problem with app not being an argument in httpx anymore (since the release on Nov 28th will be fixed in another PR, I guess)
See: https://github.com/encode/httpx/blob/master/CHANGELOG.md
|
Merged master into this to get the ci fixes in |
sentrivana
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncio_default_fixture_loop_scopetofunctionto get rid of deprecation messagestest_asyncio.pyevent loop scopes tomoduleto avoid that event loop bleeding into all other tests in the samesession.event_loops sincepytest-asynciotakes care of those