fix(django): Fix errors when instrumenting Django cache #3855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing Spotlight with Sentry and realized things started to get slow and crashy. It looks like sometimes
args
is just an empty array on cache's_instruments_call
causing lots of exceptions being thrown. This patch fixes that with explicit length checks and also adds a note for the missing instrumentation forget_or_set
method. This might be related to #2122 and #3300.