Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy scope.client reference as well #3857

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

No description provided.

@sl0thentr0py sl0thentr0py force-pushed the neel/copy-scope-client-ref branch from ed7ee5f to f800b34 Compare December 5, 2024 14:07
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (5a09770) to head (f800b34).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3857   +/-   ##
=======================================
  Coverage   79.90%   79.91%           
=======================================
  Files         137      137           
  Lines       15400    15401    +1     
  Branches     2619     2619           
=======================================
+ Hits        12306    12307    +1     
  Misses       2221     2221           
  Partials      873      873           
Files with missing lines Coverage Δ
sentry_sdk/scope.py 85.51% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this!

@sl0thentr0py sl0thentr0py merged commit 7a6d460 into master Dec 5, 2024
136 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/copy-scope-client-ref branch December 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants