Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking] Enable Django cache_spans by default #3994

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

BYK
Copy link
Member

@BYK BYK commented Jan 24, 2025

This reverts commit 955108e (#3791) and simply enables cache_spans by default..

This reverts commit 955108e (#3791) and simply enables `cache_spans` by default..
@BYK BYK requested a review from antonpirker January 24, 2025 21:55
Copy link

codecov bot commented Jan 24, 2025

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
20457 9 20448 4415
View the top 3 failed test(s) by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_breadcrumbs
Stack Traces | 0.054s run time
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7.../clickhouse_driver/dbapi/cursor.py:113: in execute
    **execute_kwargs
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:370: in execute
    with self.disconnect_on_error(query, settings):
.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/contextlib.py:112: in __enter__
    return next(self.gen)
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:313: in disconnect_on_error
    self.establish_connection(settings)
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:300: in establish_connection
    self.connection.force_connect()
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7....../site-packages/clickhouse_driver/connection.py:258: in force_connect
    self.connect()
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7....../site-packages/clickhouse_driver/connection.py:420: in connect
    raise err
E   clickhouse_driver.errors.NetworkError: Code: 210. Connection refused (localhost:9000)

During handling of the above exception, another exception occurred:
.../integrations/clickhouse_driver/test_clickhouse_driver.py:508: in test_clickhouse_dbapi_breadcrumbs
    cursor.execute("DROP TABLE IF EXISTS test")
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7.../clickhouse_driver/dbapi/cursor.py:117: in execute
    raise OperationalError(orig)
E   clickhouse_driver.dbapi.errors.OperationalError: Code: 210. Connection refused (localhost:9000)
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_client_breadcrumbs_with_pii
Stack Traces | 0.055s run time
.../integrations/clickhouse_driver/test_clickhouse_driver.py:130: in test_clickhouse_client_breadcrumbs_with_pii
    client.execute("DROP TABLE IF EXISTS test")
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:370: in execute
    with self.disconnect_on_error(query, settings):
.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/contextlib.py:112: in __enter__
    return next(self.gen)
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:313: in disconnect_on_error
    self.establish_connection(settings)
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:300: in establish_connection
    self.connection.force_connect()
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7....../site-packages/clickhouse_driver/connection.py:258: in force_connect
    self.connect()
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7....../site-packages/clickhouse_driver/connection.py:420: in connect
    raise err
E   clickhouse_driver.errors.NetworkError: Code: 210. Connection refused (localhost:9000)
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_breadcrumbs_with_pii
Stack Traces | 0.055s run time
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7.../clickhouse_driver/dbapi/cursor.py:113: in execute
    **execute_kwargs
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:370: in execute
    with self.disconnect_on_error(query, settings):
.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/contextlib.py:112: in __enter__
    return next(self.gen)
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:313: in disconnect_on_error
    self.establish_connection(settings)
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7........./site-packages/clickhouse_driver/client.py:300: in establish_connection
    self.connection.force_connect()
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7....../site-packages/clickhouse_driver/connection.py:258: in force_connect
    self.connect()
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7....../site-packages/clickhouse_driver/connection.py:420: in connect
    raise err
E   clickhouse_driver.errors.NetworkError: Code: 210. Connection refused (localhost:9000)

During handling of the above exception, another exception occurred:
.../integrations/clickhouse_driver/test_clickhouse_driver.py:605: in test_clickhouse_dbapi_breadcrumbs_with_pii
    cursor.execute("DROP TABLE IF EXISTS test")
.tox/py3.7-clickhouse_driver-v0.2.9/lib/python3.7.../clickhouse_driver/dbapi/cursor.py:117: in execute
    raise OperationalError(orig)
E   clickhouse_driver.dbapi.errors.OperationalError: Code: 210. Connection refused (localhost:9000)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker added the Breaking change needs to go out in a major label Feb 20, 2025
@antonpirker antonpirker changed the title breaking: Enable Django cache_spans by default [breaking] Enable Django cache_spans by default Feb 20, 2025
@antonpirker antonpirker changed the title [breaking] Enable Django cache_spans by default [breaking] Enable Django cache_spans by default Feb 20, 2025
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

We will probably release this with version 3.0 of the SDK. (which will be done in a couple of weeks/months)

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just put this here that not accidentally someone merges this. see my other review above for the real review :-)

@sentrivana sentrivana changed the base branch from master to potel-base April 10, 2025 10:06
@sentrivana sentrivana requested a review from a team as a code owner April 10, 2025 10:06
@sentrivana
Copy link
Contributor

Changed base to the 3.x branch, we can now merge

@sentrivana sentrivana merged commit cc90218 into potel-base Apr 10, 2025
125 of 127 checks passed
@sentrivana sentrivana deleted the byk/breaking/enableg-cache-spans-default branch April 10, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change needs to go out in a major SDK 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants