-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Enable Django cache_spans
by default
#3994
[breaking] Enable Django cache_spans
by default
#3994
Conversation
❌ 9 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
cache_spans
by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
We will probably release this with version 3.0 of the SDK. (which will be done in a couple of weeks/months)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just put this here that not accidentally someone merges this. see my other review above for the real review :-)
Changed base to the 3.x branch, we can now merge |
This reverts commit 955108e (#3791) and simply enables
cache_spans
by default..