Skip to content

chore: Deprecate same_process_as_parent #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

chore: Deprecate same_process_as_parent #4244

merged 1 commit into from
Apr 9, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 4, 2025 •
edited
Loading

Preparing to remove this in #4201

@sentrivana sentrivana mentioned this pull request Apr 4, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (6a1364d) to head (c0631a3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/tracing.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4244      +/-   ##
==========================================
+ Coverage   79.50%   79.57%   +0.06%     
==========================================
  Files         142      142              
  Lines       15898    15900       +2     
  Branches     2721     2722       +1     
==========================================
+ Hits        12640    12652      +12     
+ Misses       2391     2382       -9     
+ Partials      867      866       -1
Files with missing lines Coverage Δ
sentry_sdk/tracing.py 77.62% <50.00%> (-0.12%) ⬇️

... and 5 files with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review April 8, 2025 10:42
@sentrivana sentrivana requested a review from a team as a code owner April 8, 2025 10:42
@sentrivana sentrivana requested a review from antonpirker April 8, 2025 10:42
antonpirker
antonpirker approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sentrivana sentrivana force-pushed the ivana/deprecate-span-args branch from 3350777 to c0631a3 Compare April 9, 2025 08:40
@sentrivana sentrivana changed the title chore: Deprecate explicit sampled, same_process_as_parent chore: Deprecate same_process_as_parent Apr 9, 2025
@sentrivana
Copy link
Contributor Author

sentrivana commented Apr 9, 2025 •
edited
Loading

Note: removed the sampled deprecation (and I'll remove it from the follow up PR where I got rid of it on potel-base). We can keep this in order to make people's transition to 3.x easier.

@sentrivana sentrivana merged commit e05ed0a into master Apr 9, 2025
137 of 138 checks passed
@sentrivana sentrivana deleted the ivana/deprecate-span-args branch April 9, 2025 08:57
sentrivana added a commit that referenced this pull request Apr 9, 2025
@sentrivana
chore: Make start_span fail if unsupported args are provided (#4201)
9e48965 
Make the `Span` constructor actually fail if it gets unsupported
arguments, as opposed to silently ignoring them, so that folks get
notified early.

Deprecating some of these in
#4244

Closes #4200
sentrivana added a commit that referenced this pull request Apr 14, 2025
@sentrivana
Revert "chore: Deprecate same_process_as_parent (#4244)"
756db70 
This reverts commit e05ed0a.
sentrivana added a commit that referenced this pull request Apr 15, 2025
@sentrivana
Revert "chore: Deprecate same_process_as_parent (#4244)" (#4290)
706d2d2 
This reverts commit e05ed0a.

`same_process_as_parent` is `True` by default, so we actually don't have
a way of detecting whether this was set explicitly by the user or not.

Removing the deprecation altogether -- no one's using this.

Closes #4289
jirikuncar
jirikuncar reviewed Apr 15, 2025
View reviewed changes
sentry_sdk/tracing.py
@@ -323,6 +323,13 @@ def __init__(

self.scope = self.scope or hub.scope

if same_process_as_parent is not None:

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar left review comments

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sentrivana @jirikuncar @antonpirker