fix(client): use _setupIntegrations to extend both init and publi…

…c `setupIntegrations` (#3882)
getsentry · Jun 13, 2024 · 9fc8151 · 9fc8151
1 parent f2f3399
commit 9fc8151
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
 ### Fixes
 
 - Add more expressive debug logs to Native Frames Integration ([#3880](https://github.com/getsentry/sentry-react-native/pull/3880))
+- Add missing tracing integrations when using `client.init()` ([#3882](https://github.com/getsentry/sentry-react-native/pull/3882))
 
 ### Dependencies
 

diff --git a/src/js/client.ts b/src/js/client.ts
@@ -109,8 +109,8 @@ export class ReactNativeClient extends BaseClient<ReactNativeClientOptions> {
   /**
    * Sets up the integrations
    */
-  public setupIntegrations(): void {
-    super.setupIntegrations();
+  protected _setupIntegrations(): void {
+    super._setupIntegrations();
     const tracing = this.getIntegration(ReactNativeTracing);
     const routingName = tracing?.options.routingInstrumentation?.name;
     if (routingName) {

diff --git a/test/client.test.ts b/test/client.test.ts
@@ -667,6 +667,22 @@ describe('Tests ReactNativeClient', () => {
       expect(client.getIntegrationById('ReactNativeUserInteractionTracing')).toBeTruthy();
     });
 
+    test('register user interactions tracing - init()', () => {
+      const client = new ReactNativeClient(
+        mockedOptions({
+          dsn: EXAMPLE_DSN,
+          integrations: [
+            new ReactNativeTracing({
+              enableUserInteractionTracing: true,
+            }),
+          ],
+        }),
+      );
+      client.init();
+
+      expect(client.getIntegrationById('ReactNativeUserInteractionTracing')).toBeTruthy();
+    });
+
     test('do not register user interactions tracing', () => {
       const client = new ReactNativeClient(
         mockedOptions({
@@ -682,6 +698,22 @@ describe('Tests ReactNativeClient', () => {
 
       expect(client.getIntegrationById('ReactNativeUserInteractionTracing')).toBeUndefined();
     });
+
+    test('do not register user interactions tracing - init()', () => {
+      const client = new ReactNativeClient(
+        mockedOptions({
+          dsn: EXAMPLE_DSN,
+          integrations: [
+            new ReactNativeTracing({
+              enableUserInteractionTracing: false,
+            }),
+          ],
+        }),
+      );
+      client.init();
+
+      expect(client.getIntegrationById('ReactNativeUserInteractionTracing')).toBeUndefined();
+    });
   });
 });