Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Replay - react-native-webview maskAllText #4126

Open
5 tasks
ph8nt0m opened this issue Sep 29, 2024 · 2 comments
Open
5 tasks

Session Replay - react-native-webview maskAllText #4126

ph8nt0m opened this issue Sep 29, 2024 · 2 comments

Comments

@ph8nt0m
Copy link

ph8nt0m commented Sep 29, 2024

OS:

  • Windows
  • [O] MacOS
  • Linux

Platform:

  • [O] iOS
  • [O] Android

SDK:

  • [O] @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: ^5.31.1

react-native version: 0.74.5

Are you using Expo?

  • [O] Yes (Bare Workflow)
  • No

Are you using sentry.io or on-premise?

  • [O] sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

[Link to issue]

Configuration:

ReactNativeSentry.init({
dsn: 'https://e96105128d654a5681e011b4be3e29cd@o4504245640232960.ingest.sentry.io/4504245656420352',
_experiments: {
replaysSessionSampleRate: 1.0,
replaysOnErrorSampleRate: 1.0,
profilesSampleRate: 1.0,
},

  environment: envs.envName,
  release: envs.version,

  debug: false,
  maxBreadcrumbs: 150,

  enableAutoSessionTracking: true,
  sessionTrackingIntervalMillis: 10000,

  integrations: [
    Sentry.mobileReplayIntegration({
      maskAllText: true,
      maskAllImages: true,
    }),
    new Sentry.ReactNativeTracing({
      idleTimeout: 5000,
      routingInstrumentation: reactNavigationInstrumentation,
      tracingOrigins: ['localhost', /^\//, /^https:\/\//],
    }),
  ],
  tracesSampleRate: 1.0,
}),

---
If I use react-native-webview, Text and images within the web view are not hidden.

Text and images outside the web view are easily obscured.
@krystofwoldrich
Copy link
Member

Hi @ph8nt0m,
thank you for the message,

this seems like a bug, the WebViews in RN Replays should be completely redacted by default.

As we are not able to read the web elements from the native Android and iOS layers where the RN replays is recorded we decided to completely redact WebViews.

@krystofwoldrich
Copy link
Member

As a park of reproducing the issue let's add https://github.com/react-native-webview/react-native-webview to our sample app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Status: Needs Discussion
Development

No branches or pull requests

3 participants