Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/perf tests #2430

Merged
merged 17 commits into from
Sep 13, 2022
Merged

Ci/perf tests #2430

merged 17 commits into from
Sep 13, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Aug 21, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

See the overall issue at getsentry/team-mobile#5 and the sibling PR at sentry-java for the approach & some more details: getsentry/sentry-java#2171

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@vaind vaind mentioned this pull request Aug 21, 2022
8 tasks
@vaind vaind changed the base branch from main to 5.0.0 September 1, 2022 17:21
@vaind vaind force-pushed the ci/perf-tests branch 5 times, most recently from 8a98b14 to 634b734 Compare September 2, 2022 14:59
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

iOS Performance metrics 🚀

Plain With Sentry Diff
Startup time (ms) 1239.53 1260.58 21.05
Size (bytes) 1133619 1504636 371017

@marandaneto
Copy link
Contributor

@vaind is there something we can help with here? tests are failing so not sure what's pending.

@vaind
Copy link
Collaborator Author

vaind commented Sep 5, 2022

@vaind is there something we can help with here? tests are failing so not sure what's pending.

No, now that the secrets are set up (that took a while) I can have a look at the failing android test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Android Performance metrics 🚀

Plain With Sentry Diff
Startup time (ms) 311.87 326.22 14.34
Size (bytes) 27072261 29211216 2138955

@vaind vaind marked this pull request as ready for review September 9, 2022 07:04
@marandaneto
Copy link
Contributor

@vaind the iOS error seems to be related to actions/runner-images#4545
It's an issue that happens from time to time, usually retriggering helps but @jennmueng tried to fix it a while ago and could not find the culprit or how to fix it once and for all.
@krystofwoldrich also tried recently.
So either retrigger to make it pass or take a stab at fixing it.
Thanks.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaind

@marandaneto marandaneto merged commit de7da04 into 5.0.0 Sep 13, 2022
@marandaneto marandaneto deleted the ci/perf-tests branch September 13, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants