Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the new architecture sample to RN 0.71.1 with Cpp module #2796

Merged
merged 11 commits into from
Feb 3, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Jan 30, 2023

Removed manual linking of the java module## 📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

The new RN version 0.71 introduced a simplified interface for pure Cpp native modules.

💡 Motivation and Context

Screenshot 2023-01-30 at 10 09 50

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 270.37 ms 307.29 ms 36.92 ms
Size 7.15 MiB 8.07 MiB 948.94 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 321.42 ms 342.74 ms 21.32 ms
d091239+dirty 340.16 ms 366.42 ms 26.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 7.15 MiB 8.00 MiB 874.27 KiB
d091239+dirty 7.15 MiB 8.00 MiB 874.38 KiB

@marandaneto
Copy link
Contributor

@krystofwoldrich I wonder if after all those changes the SDK is still compatible with 0.69 and 0.70?

@krystofwoldrich
Copy link
Member Author

@krystofwoldrich I wonder if after all those changes the SDK is still compatible with 0.69 and 0.70?

All the changes here are only in the sample app. These changes only reflect the changes in the default RN init template. There was no change to our SDK.

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 348.40 ms 360.06 ms 11.67 ms
Size 17.73 MiB 20.03 MiB 2.30 MiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 339.52 ms 369.84 ms 30.32 ms
d091239+dirty 425.61 ms 447.11 ms 21.50 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 17.73 MiB 19.95 MiB 2.22 MiB
d091239+dirty 17.73 MiB 19.95 MiB 2.22 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1278.00 ms 1286.96 ms 8.96 ms
Size 2.36 MiB 2.81 MiB 460.60 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 1274.90 ms 1305.68 ms 30.78 ms
d091239+dirty 1251.49 ms 1276.75 ms 25.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 2.36 MiB 2.74 MiB 384.64 KiB
d091239+dirty 2.36 MiB 2.74 MiB 384.64 KiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1286.86 ms 1293.40 ms 6.54 ms
Size 2.92 MiB 3.37 MiB 461.65 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 1253.68 ms 1253.94 ms 0.26 ms
d091239+dirty 1261.62 ms 1275.80 ms 14.17 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 2.92 MiB 3.30 MiB 387.19 KiB
d091239+dirty 2.92 MiB 3.30 MiB 387.22 KiB

@krystofwoldrich krystofwoldrich merged commit 9687ca8 into 5.0.0 Feb 3, 2023
@krystofwoldrich krystofwoldrich deleted the add-pure-cpp-module branch February 3, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants