Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): Add routing instrumentations report in integrations #2798

Merged
merged 7 commits into from
Feb 6, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Feb 1, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

closes: #2210

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4a972da

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 361.42 ms 389.50 ms 28.08 ms
Size 17.73 MiB 20.03 MiB 2.30 MiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 339.52 ms 369.84 ms 30.32 ms
d091239+dirty 425.61 ms 447.11 ms 21.50 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 17.73 MiB 19.95 MiB 2.22 MiB
d091239+dirty 17.73 MiB 19.95 MiB 2.22 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.98 ms 1256.46 ms 16.48 ms
Size 2.36 MiB 2.81 MiB 461.96 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 1274.90 ms 1305.68 ms 30.78 ms
d091239+dirty 1251.49 ms 1276.75 ms 25.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 2.36 MiB 2.74 MiB 384.64 KiB
d091239+dirty 2.36 MiB 2.74 MiB 384.64 KiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 261.38 ms 302.76 ms 41.38 ms
Size 7.15 MiB 8.08 MiB 956.12 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 321.42 ms 342.74 ms 21.32 ms
d091239+dirty 340.16 ms 366.42 ms 26.26 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 7.15 MiB 8.00 MiB 874.27 KiB
d091239+dirty 7.15 MiB 8.00 MiB 874.38 KiB

@marandaneto
Copy link
Contributor

Can we also do that for other features that require a setup, such as https://docs.sentry.io/platforms/react-native/touchevents/ and https://docs.sentry.io/platforms/react-native/performance/instrumentation/automatic-instrumentation/#react-profiler

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1282.16 ms 1284.54 ms 2.38 ms
Size 2.92 MiB 3.37 MiB 462.98 KiB

Baseline results on branch: 5.0.0

Startup times

Revision Plain With Sentry Diff
b868b53+dirty 1253.68 ms 1253.94 ms 0.26 ms
d091239+dirty 1261.62 ms 1275.80 ms 14.17 ms

App size

Revision Plain With Sentry Diff
b868b53+dirty 2.92 MiB 3.30 MiB 387.19 KiB
d091239+dirty 2.92 MiB 3.30 MiB 387.22 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review February 3, 2023 11:20
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a last comment otherwise LGTM

@krystofwoldrich krystofwoldrich merged commit e135fed into 5.0.0 Feb 6, 2023
@krystofwoldrich krystofwoldrich deleted the report-top-level-integrations branch February 6, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants