chore(sample): Bump repository to React Native 0.73 #3346

krystofwoldrich · 2023-10-16T08:18:02Z

📢 Type of change

Enhancement
Refactoring

📜 Description

Test the SDK with the upcoming 0.73.0-rc.2

changes for libs in 0.73 [Android] Upcoming changes for libraries in React Native 0.73 react-native-community/discussions-and-proposals#671

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

#skip-changelog

github-actions · 2023-10-16T08:46:19Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.55 ms	1217.61 ms	3.06 ms
Size	2.36 MiB	2.88 MiB	524.07 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`27ef4ee`+dirty	1293.52 ms	1296.08 ms	2.56 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`e5c9b8b`+dirty	1258.57 ms	1267.32 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`27ef4ee`+dirty	2.36 MiB	2.85 MiB	500.03 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`e5c9b8b`+dirty	2.36 MiB	2.87 MiB	520.43 KiB

github-actions · 2023-10-16T09:00:23Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	439.59 ms	459.88 ms	20.29 ms
Size	17.73 MiB	19.84 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`575f9da`	415.26 ms	422.98 ms	7.72 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`f06c879`	408.41 ms	424.54 ms	16.13 ms

App size

Revision	Plain	With Sentry	Diff
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`575f9da`	17.73 MiB	19.83 MiB	2.10 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`f06c879`	17.73 MiB	19.85 MiB	2.12 MiB

github-actions · 2023-10-16T09:06:28Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	368.23 ms	419.22 ms	50.99 ms
Size	7.15 MiB	8.11 MiB	988.69 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`9c48b2c`+dirty	270.82 ms	321.12 ms	50.30 ms
`27ef4ee`+dirty	296.71 ms	351.00 ms	54.29 ms
`6e8584e`+dirty	383.37 ms	400.84 ms	17.47 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`9c48b2c`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`27ef4ee`+dirty	7.15 MiB	8.08 MiB	959.49 KiB
`6e8584e`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB

github-actions · 2023-10-16T10:18:13Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1256.80 ms	1274.57 ms	17.77 ms
Size	2.92 MiB	3.43 MiB	524.97 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`27ef4ee`+dirty	1236.41 ms	1244.90 ms	8.49 ms
`6e8584e`+dirty	1271.71 ms	1281.26 ms	9.55 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`e5c9b8b`+dirty	1276.90 ms	1280.92 ms	4.02 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`27ef4ee`+dirty	2.92 MiB	3.41 MiB	503.72 KiB
`6e8584e`+dirty	2.92 MiB	3.44 MiB	536.52 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`e5c9b8b`+dirty	2.92 MiB	3.43 MiB	524.50 KiB

This reverts commit ad46638.

krystofwoldrich · 2023-11-24T12:54:47Z

react-native-safe-area-context patch can be removed when th3rdwave/react-native-safe-area-context#454 is released

krystofwoldrich · 2023-11-24T15:03:33Z

react-native-screens patch can be remove after release software-mansion/react-native-screens#1972

.github/workflows/codegen.yml

.github/workflows/e2e.yml

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

lucas-zimerman

LGTM!

krystofwoldrich · 2023-12-13T10:43:31Z

The E2E Tests of 0.73 iOS New Architecture are timing out. We need to check if it's a flaky test or if something is broken.

krystofwoldrich · 2024-01-08T10:03:47Z

All iOS builds are currently failing due to Pod install error verification checksum was incorrect at boost (1.83.0) facebook/react-native#42109
New iOS Arch timeouts likely caused by 0.72.8: iOS HTTP load failed, 0/0 bytes (error code: -1003 [12:8]) facebook/react-native#42123

krystofwoldrich · 2024-01-08T10:11:17Z

I'll merge this to unblock chore(sample): Update Expo sample to SDK 50 beta 0 #3463
When the RN fix is released we need to revisit the CI tests and check everything passes

Bump e2e tests to 0.73.0-rc.2

acbf6b2

krystofwoldrich added 2 commits October 16, 2023 11:41

Upgrade java version for the new react native

953aba0

Include prerelease xcode patch script

28b0acb

krystofwoldrich changed the title ~~Bump e2e tests to 0.73.0-rc.2~~ Bump e2e tests to 0.73 RC Oct 23, 2023

krystofwoldrich added 4 commits October 23, 2023 15:23

Merge remote-tracking branch 'origin/main' into kw-rn-0-73

8df10c8

Update default xcode version to 14.3

ad46638

Revert "Update default xcode version to 14.3"

efd498d

This reverts commit ad46638.

Bump ro rc 3

1e876e3

krystofwoldrich closed this Oct 31, 2023

krystofwoldrich reopened this Oct 31, 2023

krystofwoldrich added 4 commits October 31, 2023 10:56

Merge branch 'main' into kw-rn-0-73

270edc4

Upgrade android to 0.73 (not all libs are compatible yet)

73a3774

Merge branch 'main' into kw-rn-0-73

899523c

Upgrade to latest rc, add safe area patch, fix ios project

172341b

Remove start package build phase

56fb902

krystofwoldrich added 2 commits November 24, 2023 16:06

fix android sample

70b05a5

revert sdk change

daaf8af

krystofwoldrich changed the title ~~Bump e2e tests to 0.73 RC~~ Bump repository to React Native 0.73 Nov 24, 2023

krystofwoldrich added 6 commits November 24, 2023 16:11

bump ci to node 18

c04c7c7

bump java to v17

03f4dca

Add x86_64 to bundle platforms

6198f81

keep java 11 for older builds

f31943b

Fix min ios version RN 0.73 cocoa tester

b9c4968

fix codegen java version

a6c82da

krystofwoldrich added 3 commits November 28, 2023 15:53

fix e2e build test 0.65 node version

4a27dcd

Keep node 18 for SDK build, bump down for app build

961a9b0

Remove hermes from cocoa tester as no engine is needed

c1626f0

krystofwoldrich mentioned this pull request Dec 12, 2023

chore(sample): Update Expo sample to SDK 50 beta 0 #3463

Merged

9 tasks

krystofwoldrich added 2 commits December 12, 2023 15:28

Merge branch 'main' into kw-rn-0-73

31293a0

bump to 0.73.0 stable release

9d76205

krystofwoldrich marked this pull request as ready for review December 12, 2023 14:53

krystofwoldrich requested a review from lucas-zimerman as a code owner December 12, 2023 14:53

krystofwoldrich changed the title ~~Bump repository to React Native 0.73~~ chore(sample): Bump repository to React Native 0.73 Dec 12, 2023

lucas-zimerman reviewed Dec 12, 2023

View reviewed changes

.github/workflows/codegen.yml Show resolved Hide resolved

lucas-zimerman reviewed Dec 12, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

lucas-zimerman reviewed Dec 12, 2023

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

Apply suggestions from code review

98f912a

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

krystofwoldrich requested a review from lucas-zimerman December 12, 2023 16:38

lucas-zimerman approved these changes Dec 12, 2023

View reviewed changes

krystofwoldrich added 2 commits January 5, 2024 12:33

chore(internal): Use new DSN after leaked token

9bcd0dd

Merge branch 'kw-new-dsn' into kw-rn-0-73

34f148f

krystofwoldrich changed the base branch from main to kw-new-dsn January 5, 2024 12:09

Base automatically changed from kw-new-dsn to main January 5, 2024 13:54

Merge remote-tracking branch 'origin/main' into kw-rn-0-73

0e78db6

krystofwoldrich merged commit 9f2ce14 into main Jan 8, 2024
41 of 70 checks passed

krystofwoldrich deleted the kw-rn-0-73 branch January 8, 2024 10:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(sample): Bump repository to React Native 0.73 #3346

chore(sample): Bump repository to React Native 0.73 #3346

krystofwoldrich commented Oct 16, 2023 •

edited

Loading

github-actions bot commented Oct 16, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 16, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 16, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 16, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Nov 24, 2023

krystofwoldrich commented Nov 24, 2023

lucas-zimerman left a comment

krystofwoldrich commented Dec 13, 2023 •

edited

Loading

krystofwoldrich commented Jan 8, 2024 •

edited

Loading

krystofwoldrich commented Jan 8, 2024

chore(sample): Bump repository to React Native 0.73 #3346

chore(sample): Bump repository to React Native 0.73 #3346

Conversation

krystofwoldrich commented Oct 16, 2023 • edited Loading

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

github-actions bot commented Oct 16, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 16, 2023 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 16, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 16, 2023 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Nov 24, 2023

krystofwoldrich commented Nov 24, 2023

lucas-zimerman left a comment

Choose a reason for hiding this comment

krystofwoldrich commented Dec 13, 2023 • edited Loading

krystofwoldrich commented Jan 8, 2024 • edited Loading

krystofwoldrich commented Jan 8, 2024

krystofwoldrich commented Oct 16, 2023 •

edited

Loading

github-actions bot commented Oct 16, 2023 •

edited

Loading

github-actions bot commented Oct 16, 2023 •

edited

Loading

github-actions bot commented Oct 16, 2023 •

edited

Loading

github-actions bot commented Oct 16, 2023 •

edited

Loading

krystofwoldrich commented Dec 13, 2023 •

edited

Loading

krystofwoldrich commented Jan 8, 2024 •

edited

Loading