Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds a sample turbo module to the bare React Native Sample app which can be used to demonstrate the turbo module features.

The feature added in this PR is mixed stack traces from platform modules to JavaScript.

This PR also adds a simple JS-linked error.

💡 Motivation and Context

Example iOS Error https://sentry-sdks.sentry.io/issues/4911692436/events/75621b2ba4bb49e8a608b462c542e5e0/

Screenshot 2024-01-24 at 14 13 47 Screenshot 2024-01-24 at 14 13 53

Example Android Error https://sentry-sdks.sentry.io/issues/4912520650/events/b80b61dcac2e49bc9ce15a16ff0517b3/

Screenshot 2024-01-24 at 14 12 58

Example JS Linked Error https://sentry-sdks.sentry.io/issues/4908741065/events/907d47dda77b473198cd2b76540de3c3/

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 460.71 ms 471.96 ms 11.25 ms
Size 17.73 MiB 19.91 MiB 2.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3853f43 329.68 ms 346.32 ms 16.64 ms
e2b64fe 316.88 ms 330.23 ms 13.35 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
ad6c299 375.94 ms 382.02 ms 6.08 ms

App size

Revision Plain With Sentry Diff
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
ad6c299 17.73 MiB 19.75 MiB 2.02 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1196.92 ms 1207.78 ms 10.86 ms
Size 2.36 MiB 2.90 MiB 554.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
728164b+dirty 1256.10 ms 1259.08 ms 2.98 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
728164b+dirty 2.36 MiB 2.88 MiB 530.38 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

Base automatically changed from kw-fix-linked-errors-symbolication to main January 25, 2024 05:08
@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 358.78 ms 386.40 ms 27.62 ms
Size 7.15 MiB 8.18 MiB 1.03 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
575f9da+dirty 337.15 ms 370.47 ms 33.32 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
34aba08+dirty 331.79 ms 376.69 ms 44.91 ms
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms

App size

Revision Plain With Sentry Diff
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
575f9da+dirty 7.15 MiB 8.10 MiB 979.68 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
34aba08+dirty 7.15 MiB 8.07 MiB 946.13 KiB
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman merged commit bc4b9f6 into main Feb 15, 2024
@lucas-zimerman lucas-zimerman deleted the kw-add-platform-sample-module branch February 15, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants