Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal): Remove deprecated JS SDK code #3576

Closed
wants to merge 42 commits into from

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the base branch from main to kw-fix-js February 2, 2024 18:44
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove deprecated JS SDK code ([#3576](https://github.com/getsentry/sentry-react-native/pull/3576))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 0c01575

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 475.36 ms 502.56 ms 27.20 ms
Size 17.73 MiB 19.93 MiB 2.20 MiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc 407.08 ms 438.22 ms 31.14 ms

App size

Revision Plain With Sentry Diff
56d9dcc 17.73 MiB 19.90 MiB 2.17 MiB

Copy link
Contributor

github-actions bot commented Feb 2, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1202.57 ms 1203.63 ms 1.06 ms
Size 2.36 MiB 2.92 MiB 569.53 KiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc+dirty 1241.27 ms 1246.61 ms 5.35 ms

App size

Revision Plain With Sentry Diff
56d9dcc+dirty 2.36 MiB 2.90 MiB 552.83 KiB

Copy link
Contributor

github-actions bot commented Feb 2, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.91 ms 1242.73 ms 6.82 ms
Size 2.92 MiB 3.48 MiB 575.08 KiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc+dirty 1236.80 ms 1237.98 ms 1.17 ms

App size

Revision Plain With Sentry Diff
56d9dcc+dirty 2.92 MiB 3.46 MiB 557.25 KiB

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 367.77 ms 409.09 ms 41.32 ms
Size 7.15 MiB 8.20 MiB 1.06 MiB

Previous results on branch: kw-fix-deprecations

Startup times

Revision Plain With Sentry Diff
56d9dcc+dirty 340.87 ms 374.77 ms 33.90 ms

App size

Revision Plain With Sentry Diff
56d9dcc+dirty 7.15 MiB 8.18 MiB 1.03 MiB

Base automatically changed from kw-fix-js to main February 5, 2024 17:41
@krystofwoldrich krystofwoldrich changed the base branch from main to v6 March 26, 2024 13:00
@krystofwoldrich krystofwoldrich changed the base branch from v6 to kw-sdk-tests-update March 26, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants