Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(4) ref(tracing): Extract UserInteractionTracing as standalone interaction #3999

Merged
merged 37 commits into from
Aug 13, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Aug 7, 2024

📢 Type of change

  • Refactoring

📜 Description

This PR moved User Interaction Tracing to a standalone integration.

To do so this PR refactors part of ReactNativeTracing. Introducing ReactNative specific startIdleSpan and startIdleNavigationSpan. These function are used in both ReactNativeTracing and User Interaction Tracing integrations.

Moving the tracking to a standalone integration will let us measure usage of this feature (enabled integrations telemetry).

This PR introduces user facing breaking change.

Before

import Sentry from '@sentry/react-native';
Sentry.init({
  tracesSampleRate: 1.0,
  integrations: [
    new Sentry.ReactNativeTracing({
      enableUserInteractionTracing: true, // default false
    }),
  ],
});

After

import Sentry from '@sentry/react-native';
Sentry.init({
  tracesSampleRate: 1.0,
  enableUserInteractionTracing: true, // default false
});

💚 How did you test it?

sample app, tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Predecessor to this PR

krystofwoldrich and others added 30 commits June 3, 2024 18:39
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@krystofwoldrich krystofwoldrich changed the base branch from kw/rn-tracing-removed-deprecated-options to kw/ref-stall-tracking-integration August 7, 2024 13:00
@krystofwoldrich krystofwoldrich marked this pull request as ready for review August 7, 2024 13:46
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 425.46 ms 463.49 ms 38.03 ms
Size 17.73 MiB 20.04 MiB 2.31 MiB

Copy link
Contributor

github-actions bot commented Aug 7, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.96 ms 1228.84 ms -2.12 ms
Size 2.36 MiB 3.06 MiB 714.07 KiB

Copy link
Contributor

github-actions bot commented Aug 7, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.29 ms 1238.71 ms -1.58 ms
Size 2.92 MiB 3.62 MiB 719.93 KiB

@lucas-zimerman
Copy link
Collaborator

PR description says This PR introduces user facing breaking change. but on Checklist you marked No breaking changes?

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note on the PR description, but nothing blocking the PR, LGTM!

@krystofwoldrich krystofwoldrich changed the title ref(tracing): Extract UserInteractionTracing as standalone interaction (4) ref(tracing): Extract UserInteractionTracing as standalone interaction Aug 8, 2024
Base automatically changed from kw/ref-stall-tracking-integration to v6 August 13, 2024 08:18
@krystofwoldrich krystofwoldrich merged commit df80375 into v6 Aug 13, 2024
6 of 7 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/ref-user-interaction-integration branch August 13, 2024 08:26
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Extract UserInteractionTracing as standalone interaction ([#3999](https://github.com/getsentry/sentry-react-native/pull/3999))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 76c22b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants