Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update scripts/update-javascript.sh to 8.30.0 #4078

Merged
merged 5 commits into from
Sep 12, 2024
Merged

chore: update scripts/update-javascript.sh to 8.30.0 #4078

merged 5 commits into from
Sep 12, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Sep 11, 2024 •
edited
Loading

No description provided.

@krystofwoldrich krystofwoldrich changed the title feat: Add Sentry Span Origin (#4066) chore: update scripts/update-javascript.sh to 8.28.0 Sep 11, 2024
@krystofwoldrich krystofwoldrich mentioned this pull request Sep 11, 2024
Merged
@krystofwoldrich krystofwoldrich changed the title chore: update scripts/update-javascript.sh to 8.28.0 chore: update scripts/update-javascript.sh to 8.30.0 Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.98 ms 1224.41 ms -8.57 ms
Size 2.36 MiB 3.08 MiB 733.27 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.67 ms 1237.71 ms -7.97 ms
Size 2.92 MiB 3.64 MiB 739.18 KiB

lucas-zimerman
lucas-zimerman reviewed Sep 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lucas-zimerman
lucas-zimerman reviewed Sep 11, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
lucas-zimerman
lucas-zimerman approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments in regard to wrong version on changelog, after fixing it, LGTM!

@krystofwoldrich @lucas-zimerman
Apply suggestions from code review
bd2673a 
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 537.37 ms 537.87 ms 0.50 ms
Size 17.74 MiB 20.06 MiB 2.33 MiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 370.35 ms 402.76 ms 32.40 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

@krystofwoldrich krystofwoldrich merged commit 152f8d7 into v6 Sep 12, 2024
57 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/update-to-js-8-28 branch September 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @lucas-zimerman