Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tracePropagationTargets to all targets on mobile and same origin on the web #4083

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Sep 12, 2024

📢 Type of change

  • New feature
  • Enhancement

📜 Description

Matches tracePropagationTargets with the rest of mobile SDKs and JS v8 web defaults.

We can switch to all targets on mobiles, as RN doesn't check CORS headers.

💚 How did you test it?

unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

@krystofwoldrich krystofwoldrich changed the title Update-propagations-targets feat: tracePropagationTargets to all targets on mobile and same origin on the web Sep 12, 2024
Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 87ee67e

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.85 ms 1220.96 ms -2.89 ms
Size 2.36 MiB 3.08 MiB 733.33 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 423.85 ms 502.92 ms 79.07 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 478.49 ms 516.40 ms 37.91 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.55 ms 1228.82 ms -0.73 ms
Size 2.92 MiB 3.64 MiB 739.15 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 5a5c4b4 into v6 Sep 12, 2024
59 of 60 checks passed
@krystofwoldrich krystofwoldrich deleted the update-propagations-targets branch September 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants