Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes run samples scripts for iOS and Android #4098

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Sep 18, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This changes the run-ios and run-android scripts to use sequential commands instead of run-s

💡 Motivation and Context

I've run into the following error while trying to run the samples on v6

$ yarn run-ios
ERROR: Task not found: "cd", samples/react-native", yarn", react-native"
$ yarn run-android
ERROR: Task not found: "cd", samples/react-native", yarn", react-native"

💚 How did you test it?

Run the following commands from sentry-react-native project root:

yarn run-ios
yarn run-android

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 480.31 ms 499.64 ms 19.33 ms
Size 17.74 MiB 20.06 MiB 2.33 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902 484.04 ms 487.57 ms 3.53 ms

App size

Revision Plain With Sentry Diff
f77a902 17.74 MiB 20.06 MiB 2.33 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1244.65 ms 1246.53 ms 1.88 ms
Size 2.36 MiB 3.08 MiB 733.29 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 384.79 ms 429.33 ms 44.54 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 478.49 ms 516.40 ms 37.91 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.33 ms 1221.63 ms 0.30 ms
Size 2.92 MiB 3.64 MiB 739.18 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB

@lucas-zimerman
Copy link
Collaborator

Thank you for the PR!
LGTM!

@antonis antonis merged commit ffd7cfe into v6 Sep 19, 2024
58 of 59 checks passed
@antonis antonis deleted the antonis/run-samples-script-fix branch September 19, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants