Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maskAllImages JSDoc comment #4101

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix maskAllImages JSDoc comment #4101

merged 2 commits into from
Sep 23, 2024

Conversation

HarryHighPants
Copy link
Contributor

@HarryHighPants HarryHighPants commented Sep 19, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Internal

📜 Description

Update the JDoc comment to make it reflect the right MobileReplayOptions setting

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • [] All tests passing
  • [] No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis mentioned this pull request Sep 19, 2024
Merged
@lucas-zimerman
Copy link
Collaborator

Thank you for your contribution!

@lucas-zimerman lucas-zimerman merged commit fd21b24 into getsentry:main Sep 23, 2024
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@antonis antonis Awaiting requested review from antonis antonis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarryHighPants @lucas-zimerman