-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add action to warn about potentially risky PR changes #4129
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
86d6d2c+dirty | 267.21 ms | 325.24 ms | 58.04 ms |
5a22220+dirty | 384.61 ms | 419.06 ms | 34.45 ms |
700cbf4+dirty | 411.71 ms | 485.52 ms | 73.81 ms |
0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
ad6c299+dirty | 336.47 ms | 362.89 ms | 26.42 ms |
f06c879+dirty | 361.27 ms | 407.88 ms | 46.61 ms |
5bb8d5f+dirty | 356.71 ms | 389.65 ms | 32.94 ms |
76d1baf+dirty | 339.02 ms | 408.65 ms | 69.63 ms |
728164b+dirty | 335.93 ms | 342.94 ms | 7.01 ms |
d0bf494+dirty | 253.73 ms | 308.23 ms | 54.49 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
86d6d2c+dirty | 7.15 MiB | 8.09 MiB | 962.69 KiB |
5a22220+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
700cbf4+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
ad6c299+dirty | 7.15 MiB | 8.04 MiB | 912.17 KiB |
f06c879+dirty | 7.15 MiB | 8.12 MiB | 997.78 KiB |
5bb8d5f+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
76d1baf+dirty | 7.15 MiB | 8.09 MiB | 964.41 KiB |
728164b+dirty | 7.15 MiB | 8.12 MiB | 997.71 KiB |
d0bf494+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
4a6664f+dirty | 1218.77 ms | 1221.07 ms | 2.30 ms |
52a8031+dirty | 1255.96 ms | 1273.00 ms | 17.04 ms |
d361d38+dirty | 1272.96 ms | 1291.70 ms | 18.74 ms |
15c80ab+dirty | 1248.41 ms | 1251.24 ms | 2.83 ms |
9433f35+dirty | 1232.24 ms | 1232.74 ms | 0.50 ms |
0ebca77+dirty | 1209.30 ms | 1220.33 ms | 11.03 ms |
d43a46b+dirty | 1223.31 ms | 1230.92 ms | 7.61 ms |
86d6d2c+dirty | 1291.62 ms | 1296.80 ms | 5.18 ms |
b1e8712+dirty | 1284.11 ms | 1297.82 ms | 13.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
4a6664f+dirty | 2.92 MiB | 3.60 MiB | 702.09 KiB |
52a8031+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
d361d38+dirty | 2.92 MiB | 3.41 MiB | 503.57 KiB |
15c80ab+dirty | 2.92 MiB | 3.39 MiB | 481.56 KiB |
9433f35+dirty | 2.92 MiB | 3.41 MiB | 503.55 KiB |
0ebca77+dirty | 2.92 MiB | 3.61 MiB | 705.12 KiB |
d43a46b+dirty | 2.92 MiB | 3.64 MiB | 740.29 KiB |
86d6d2c+dirty | 2.92 MiB | 3.37 MiB | 464.31 KiB |
b1e8712+dirty | 2.92 MiB | 3.40 MiB | 494.15 KiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
4a6664f+dirty | 1209.49 ms | 1208.63 ms | -0.86 ms |
52a8031+dirty | 1280.88 ms | 1289.78 ms | 8.90 ms |
d361d38+dirty | 1246.04 ms | 1267.12 ms | 21.08 ms |
15c80ab+dirty | 1223.74 ms | 1228.96 ms | 5.22 ms |
9433f35+dirty | 1246.94 ms | 1271.45 ms | 24.52 ms |
0ebca77+dirty | 1220.75 ms | 1222.81 ms | 2.06 ms |
d43a46b+dirty | 1219.24 ms | 1219.65 ms | 0.41 ms |
86d6d2c+dirty | 1267.55 ms | 1286.21 ms | 18.66 ms |
b1e8712+dirty | 1256.02 ms | 1265.14 ms | 9.12 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
4a6664f+dirty | 2.36 MiB | 3.04 MiB | 696.39 KiB |
52a8031+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
d361d38+dirty | 2.36 MiB | 2.85 MiB | 499.84 KiB |
15c80ab+dirty | 2.36 MiB | 2.83 MiB | 474.49 KiB |
9433f35+dirty | 2.36 MiB | 2.85 MiB | 499.80 KiB |
0ebca77+dirty | 2.36 MiB | 3.04 MiB | 698.33 KiB |
d43a46b+dirty | 2.36 MiB | 3.08 MiB | 734.25 KiB |
86d6d2c+dirty | 2.36 MiB | 2.82 MiB | 462.82 KiB |
b1e8712+dirty | 2.36 MiB | 2.84 MiB | 488.84 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📢 Type of change
📜 Description
Implement a mechanism that automatically adds an "alert" comment to PRs if they include changes to files we think have higher potential to break things than others.
💡 Motivation and Context
same as getsentry/sentry-java#3726 and getsentry/sentry-dart#2315
💚 How did you test it?
✅ by adding the file-filter.yml introduced in this PR to the list of potentially risky changes and ensuring that an alert is shown
📝 Checklist
I added tests to verify changesNo new PII added or SDK only sends newly added PII ifsendDefaultPII
is enabledAll tests passingNo breaking changes🔮 Next steps
#skip-changelog