Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Updates yarn command adding mode argument #4133

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 1, 2024

Depends on: #4087 to avoid any conflicts in the contributors guide for v6.

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Updates yarn commands in the Run the emulators sections and replaces the configuration and variant arguments that have been deprecated in 0.71 with the mode argument. Reference:

💡 Motivation and Context

I was getting unknown option --configuration/variant errors and inconsistency with the current scripts as reported here.

💚 How did you test it?

Run the updated commands locally

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Base automatically changed from kw/update-contributing-guide to v6 October 2, 2024 09:09
An error occurred while trying to automatically change base from kw/update-contributing-guide to v6 October 2, 2024 09:09
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 885a221 into v6 Oct 2, 2024
25 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/contributor-guide-run-release branch October 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants