Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Handles error with string cause #4163

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix: Handles error with string cause #4163

merged 3 commits into from
Oct 11, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 10, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds handling for native link errors with a string cause

💡 Motivation and Context

Fixes #3673

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis antonis marked this pull request as ready for review October 10, 2024 15:13
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 483.42 ms 477.52 ms -5.90 ms
Size 17.73 MiB 20.11 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220 412.38 ms 447.35 ms 34.97 ms
27ef4ee 317.40 ms 321.70 ms 4.30 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
728164b 414.34 ms 449.22 ms 34.88 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms

App size

Revision Plain With Sentry Diff
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
27ef4ee 17.73 MiB 19.82 MiB 2.08 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.04 ms 1219.18 ms -4.86 ms
Size 2.36 MiB 3.14 MiB 793.30 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
0ebca77+dirty 1220.75 ms 1222.81 ms 2.06 ms
acadc0f+dirty 1264.38 ms 1290.06 ms 25.68 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
70e6261+dirty 1220.09 ms 1230.04 ms 9.95 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
0ebca77+dirty 2.36 MiB 3.04 MiB 698.33 KiB
acadc0f+dirty 2.36 MiB 2.83 MiB 480.37 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
70e6261+dirty 2.36 MiB 3.03 MiB 680.42 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 640.78 ms 708.75 ms 67.97 ms
Size 7.15 MiB 8.39 MiB 1.24 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
c398f67+dirty 315.08 ms 345.60 ms 30.52 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
1c65324+dirty 381.10 ms 427.26 ms 46.16 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
0ebca77+dirty 360.94 ms 402.24 ms 41.30 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
c2a4e9b+dirty 392.94 ms 474.55 ms 81.61 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
c398f67+dirty 7.15 MiB 8.21 MiB 1.07 MiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
1c65324+dirty 7.15 MiB 8.22 MiB 1.07 MiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
0ebca77+dirty 7.15 MiB 8.22 MiB 1.07 MiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
c2a4e9b+dirty 7.15 MiB 8.34 MiB 1.19 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.63 ms 1228.56 ms -0.07 ms
Size 2.92 MiB 3.69 MiB 794.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
0ebca77+dirty 1209.30 ms 1220.33 ms 11.03 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
70e6261+dirty 1224.90 ms 1231.02 ms 6.12 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms

App size

Revision Plain With Sentry Diff
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
0ebca77+dirty 2.92 MiB 3.61 MiB 705.12 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
70e6261+dirty 2.92 MiB 3.59 MiB 686.11 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB

lucas-zimerman
lucas-zimerman approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, thanks for adding the tests!
LGTM!

krystofwoldrich
krystofwoldrich approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit 7259f12 into main Oct 11, 2024
65 checks passed
@krystofwoldrich krystofwoldrich deleted the antonis/3673-string-cause branch October 11, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in @sentry/react-native Module with Error Handling Using String Cause
3 participants
@antonis @lucas-zimerman @krystofwoldrich