Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add Mask and Unmask Wrappers for react-native-web #4272

Merged
merged 63 commits into from
Nov 26, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 13, 2024

📢 Type of change

  • New feature
  • Enhancement

📜 Description

This PR add the Mask and Unmask wrapper functions for react-native-web.

💚 How did you test it?

expo sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

krystofwoldrich and others added 30 commits October 31, 2024 17:13
…getsentry/sentry-react-native into kw/feat/replay-custom-redact-components
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 318.43 ms 349.79 ms 31.37 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms
4297324+dirty 385.33 ms 435.68 ms 50.35 ms
13f280b+dirty 376.13 ms 406.41 ms 30.28 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
8ae23a7+dirty 398.10 ms 411.48 ms 13.38 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
eb1e19f+dirty 391.37 ms 418.27 ms 26.90 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms

App size

Revision Plain With Sentry Diff
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
4297324+dirty 7.15 MiB 8.35 MiB 1.20 MiB
13f280b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
8ae23a7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
eb1e19f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review November 25, 2024 15:07
Copy link
Contributor

github-actions bot commented Nov 25, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.53 ms 1228.27 ms 0.74 ms
Size 2.36 MiB 3.10 MiB 759.74 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
4cc5c27+dirty 1211.45 ms 1214.60 ms 3.16 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
cdf2f33+dirty 1227.71 ms 1233.94 ms 6.22 ms
e1ea4a8+dirty 1233.49 ms 1237.71 ms 4.22 ms
dadc233+dirty 1223.20 ms 1236.88 ms 13.68 ms
ed3d77e+dirty 1214.61 ms 1205.83 ms -8.78 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
9cd0e9f+dirty 1224.94 ms 1239.88 ms 14.94 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms

App size

Revision Plain With Sentry Diff
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
4cc5c27+dirty 2.36 MiB 3.04 MiB 698.52 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
cdf2f33+dirty 2.36 MiB 3.10 MiB 751.38 KiB
e1ea4a8+dirty 2.36 MiB 3.10 MiB 752.31 KiB
dadc233+dirty 2.36 MiB 2.84 MiB 486.85 KiB
ed3d77e+dirty 2.36 MiB 3.10 MiB 753.32 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
9cd0e9f+dirty 2.36 MiB 3.08 MiB 735.56 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected 🎉

Base automatically changed from kw/feat/replay-custom-redact-android to main November 25, 2024 16:51
An error occurred while trying to automatically change base from kw/feat/replay-custom-redact-android to main November 25, 2024 16:51
@krystofwoldrich krystofwoldrich merged commit a11c735 into main Nov 26, 2024
55 of 56 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/feat/add-custom-mask-for-web branch November 26, 2024 06:37
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 447.41 ms 427.92 ms -19.49 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8ae23a7 526.83 ms 513.38 ms -13.45 ms
4297324 536.61 ms 542.48 ms 5.87 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
c2a4e9b 480.42 ms 485.60 ms 5.18 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
7bc4d75 488.76 ms 473.28 ms -15.48 ms
0d3e677 422.82 ms 411.90 ms -10.92 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms

App size

Revision Plain With Sentry Diff
8ae23a7 17.74 MiB 20.07 MiB 2.34 MiB
4297324 17.74 MiB 20.08 MiB 2.34 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
c2a4e9b 17.73 MiB 20.06 MiB 2.33 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
7bc4d75 17.74 MiB 20.08 MiB 2.34 MiB
0d3e677 17.74 MiB 20.07 MiB 2.34 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants