test(fix): Add sentry.source custom in the navigation span.data #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
changed the title
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1e9894e+dirty | 385.63 ms | 420.18 ms | 34.55 ms |
| 4a9de34+dirty | 385.19 ms | 429.35 ms | 44.16 ms |
| cdeca8b+dirty | 418.09 ms | 468.62 ms | 50.53 ms |
| f193e90+dirty | 370.91 ms | 498.10 ms | 127.19 ms |
| e4c23be+dirty | 379.09 ms | 412.68 ms | 33.59 ms |
| bca5c58+dirty | 369.19 ms | 401.90 ms | 32.71 ms |
| 7871424+dirty | 417.35 ms | 468.16 ms | 50.81 ms |
| c0332a6+dirty | 389.21 ms | 449.39 ms | 60.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1e9894e+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 4a9de34+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| cdeca8b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| f193e90+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| e4c23be+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| bca5c58+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 7871424+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| c0332a6+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 1235.78 ms | 1225.23 ms | -10.55 ms |
| c0332a6+dirty | 1227.13 ms | 1230.90 ms | 3.77 ms |
| 7871424+dirty | 1245.73 ms | 1235.39 ms | -10.35 ms |
| bca5c58+dirty | 1224.23 ms | 1224.90 ms | 0.66 ms |
| f193e90+dirty | 1228.43 ms | 1229.02 ms | 0.59 ms |
| 1e9894e+dirty | 1233.37 ms | 1226.96 ms | -6.41 ms |
| e4c23be+dirty | 1232.21 ms | 1230.16 ms | -2.05 ms |
| 4a9de34+dirty | 1234.35 ms | 1230.35 ms | -3.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 2.92 MiB | 3.64 MiB | 744.52 KiB |
| c0332a6+dirty | 2.92 MiB | 3.64 MiB | 742.47 KiB |
| 7871424+dirty | 2.92 MiB | 3.66 MiB | 757.21 KiB |
| bca5c58+dirty | 2.92 MiB | 3.66 MiB | 757.55 KiB |
| f193e90+dirty | 2.92 MiB | 3.64 MiB | 742.92 KiB |
| 1e9894e+dirty | 2.92 MiB | 3.66 MiB | 757.26 KiB |
| e4c23be+dirty | 2.92 MiB | 3.64 MiB | 742.98 KiB |
| 4a9de34+dirty | 2.92 MiB | 3.66 MiB | 757.67 KiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 1212.42 ms | 1223.69 ms | 11.27 ms |
| c0332a6+dirty | 1223.13 ms | 1232.31 ms | 9.18 ms |
| 7871424+dirty | 1212.69 ms | 1224.40 ms | 11.72 ms |
| bca5c58+dirty | 1208.27 ms | 1212.41 ms | 4.14 ms |
| f193e90+dirty | 1224.20 ms | 1229.10 ms | 4.90 ms |
| 1e9894e+dirty | 1213.33 ms | 1225.16 ms | 11.83 ms |
| e4c23be+dirty | 1225.25 ms | 1223.76 ms | -1.49 ms |
| 4a9de34+dirty | 1215.58 ms | 1218.76 ms | 3.17 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdeca8b+dirty | 2.36 MiB | 3.09 MiB | 743.02 KiB |
| c0332a6+dirty | 2.36 MiB | 3.08 MiB | 736.57 KiB |
| 7871424+dirty | 2.36 MiB | 3.10 MiB | 752.86 KiB |
| bca5c58+dirty | 2.36 MiB | 3.10 MiB | 752.95 KiB |
| f193e90+dirty | 2.36 MiB | 3.08 MiB | 737.28 KiB |
| 1e9894e+dirty | 2.36 MiB | 3.10 MiB | 752.76 KiB |
| e4c23be+dirty | 2.36 MiB | 3.08 MiB | 737.17 KiB |
| 4a9de34+dirty | 2.36 MiB | 3.10 MiB | 753.19 KiB |
bruno-garcia
force-pushed
the
deps/scripts/update-javascript.sh
branch
5 times, most recently
from
7a5b973
to
652045e
Compare
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7871424 | 462.63 ms | 445.80 ms | -16.83 ms |
| 1e9894e | 431.94 ms | 445.06 ms | 13.12 ms |
| c0332a6 | 461.40 ms | 456.00 ms | -5.40 ms |
| cdeca8b | 438.11 ms | 436.48 ms | -1.63 ms |
| e4c23be | 452.76 ms | 438.16 ms | -14.60 ms |
| d3ef7b9 | 486.60 ms | 474.76 ms | -11.84 ms |
| bca5c58 | 498.31 ms | 498.32 ms | 0.01 ms |
| 4a9de34 | 423.00 ms | 429.66 ms | 6.66 ms |
| f193e90 | 432.83 ms | 433.10 ms | 0.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7871424 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 1e9894e | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| c0332a6 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| cdeca8b | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| e4c23be | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| d3ef7b9 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
| bca5c58 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 4a9de34 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| f193e90 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Adds
sentry.source: customin thespan.datato fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293The change seems to be related with getsentry/sentry-javascript#14251
💡 Motivation and Context
Fix failing tests in the JavaScript SDK to v8.39.0 upgrade #4293 (comment)
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog