Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Feb 26, 2025

#skip-changelog

Fix missing NSPhotoLibraryUsageDescription for the react-native-image-picker dep.

Fixes:

ITMS-90683: Missing purpose string in Info.plist - Your app’s code references one or more APIs that access sensitive user data, or the app has one or more entitlements that permit such access. The Info.plist file for the “sentryreactnativesample.app” bundle should contain a NSPhotoLibraryUsageDescription key with a user-facing purpose string explaining clearly and completely why your app needs the data. If you’re using external libraries or SDKs, they may reference APIs that require a purpose string. While your app might not use these APIs, a purpose string is still required. For details, visit: https://developer.apple.com/documentation/uikit/protecting_the_user_s_privacy/requesting_access_to_protected_resources.

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding the permission description Krystof 🙇

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.76 ms 1220.00 ms -3.76 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f54118b+dirty 1232.98 ms 1235.73 ms 2.76 ms
d8e8c67+dirty 1222.57 ms 1226.22 ms 3.65 ms
d8668ce+dirty 1225.18 ms 1228.08 ms 2.90 ms
cdc3945+dirty 1202.43 ms 1223.65 ms 21.23 ms
ae7b03d+dirty 1221.19 ms 1224.69 ms 3.50 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
d053743+dirty 1213.69 ms 1218.88 ms 5.18 ms
e540498+dirty 1220.61 ms 1212.93 ms -7.68 ms
63ed251+dirty 1232.55 ms 1238.77 ms 6.22 ms
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms

App size

Revision Plain With Sentry Diff
f54118b+dirty 2.36 MiB 3.10 MiB 757.51 KiB
d8e8c67+dirty 2.36 MiB 3.12 MiB 779.40 KiB
d8668ce+dirty 2.36 MiB 3.08 MiB 737.08 KiB
cdc3945+dirty 2.63 MiB 3.75 MiB 1.12 MiB
ae7b03d+dirty 2.63 MiB 3.69 MiB 1.05 MiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
d053743+dirty 2.63 MiB 3.75 MiB 1.12 MiB
e540498+dirty 2.36 MiB 3.14 MiB 793.34 KiB
63ed251+dirty 2.36 MiB 3.10 MiB 752.55 KiB
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB

@github-actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.62 ms 1227.18 ms 11.56 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f54118b+dirty 1235.42 ms 1236.80 ms 1.38 ms
d8e8c67+dirty 1235.58 ms 1233.44 ms -2.15 ms
d8668ce+dirty 1249.70 ms 1242.31 ms -7.39 ms
cdc3945+dirty 1216.51 ms 1223.55 ms 7.04 ms
ae7b03d+dirty 1223.71 ms 1227.69 ms 3.98 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
d053743+dirty 1223.18 ms 1214.25 ms -8.93 ms
e540498+dirty 1254.92 ms 1247.21 ms -7.71 ms
63ed251+dirty 1223.27 ms 1222.94 ms -0.33 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms

App size

Revision Plain With Sentry Diff
f54118b+dirty 2.92 MiB 3.67 MiB 770.05 KiB
d8e8c67+dirty 2.92 MiB 3.69 MiB 790.53 KiB
d8668ce+dirty 2.92 MiB 3.64 MiB 742.99 KiB
cdc3945+dirty 3.19 MiB 4.32 MiB 1.13 MiB
ae7b03d+dirty 3.19 MiB 4.25 MiB 1.06 MiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
d053743+dirty 3.19 MiB 4.32 MiB 1.13 MiB
e540498+dirty 2.92 MiB 3.69 MiB 794.14 KiB
63ed251+dirty 2.92 MiB 3.66 MiB 757.10 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB

@kahest kahest merged commit 10e6a21 into main Feb 26, 2025
70 of 72 checks passed
@kahest kahest deleted the kw-fix-ios-sample-photo-lib branch February 26, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants