Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.15 ms 433.82 ms 15.67 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cdf2f33 469.46 ms 462.17 ms -7.29 ms
d997097 470.23 ms 475.46 ms 5.23 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
e4ac943 439.46 ms 438.20 ms -1.26 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
5f03ae9 444.88 ms 448.89 ms 4.01 ms
05b43ab 438.67 ms 496.19 ms 57.52 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
61310e1 464.42 ms 452.47 ms -11.95 ms

App size

Revision Plain With Sentry Diff
cdf2f33 17.74 MiB 20.08 MiB 2.34 MiB
d997097 17.75 MiB 20.11 MiB 2.36 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
e4ac943 17.75 MiB 20.13 MiB 2.38 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
5f03ae9 17.75 MiB 20.11 MiB 2.36 MiB
05b43ab 17.75 MiB 20.11 MiB 2.36 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
61310e1 17.74 MiB 20.08 MiB 2.35 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.14 ms 1222.06 ms -3.08 ms
Size 2.63 MiB 3.78 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f32b22a+dirty 1216.42 ms 1224.44 ms 8.02 ms
205982c+dirty 1226.83 ms 1234.36 ms 7.53 ms
d053743+dirty 1213.69 ms 1218.88 ms 5.18 ms
8b6825a+dirty 1209.50 ms 1207.22 ms -2.28 ms
27ef4ee+dirty 1293.52 ms 1296.08 ms 2.56 ms
0eacc98+dirty 1232.69 ms 1234.67 ms 1.97 ms
30189be+dirty 1205.04 ms 1226.73 ms 21.69 ms
87dd218+dirty 1215.06 ms 1218.38 ms 3.32 ms
6fd1d2b+dirty 1209.08 ms 1220.27 ms 11.18 ms
8d251c2+dirty 1220.17 ms 1225.21 ms 5.05 ms

App size

Revision Plain With Sentry Diff
f32b22a+dirty 2.63 MiB 3.76 MiB 1.13 MiB
205982c+dirty 2.36 MiB 3.11 MiB 760.04 KiB
d053743+dirty 2.63 MiB 3.75 MiB 1.12 MiB
8b6825a+dirty 2.63 MiB 3.75 MiB 1.12 MiB
27ef4ee+dirty 2.36 MiB 2.85 MiB 500.03 KiB
0eacc98+dirty 2.63 MiB 3.69 MiB 1.05 MiB
30189be+dirty 2.63 MiB 3.70 MiB 1.06 MiB
87dd218+dirty 2.63 MiB 3.76 MiB 1.13 MiB
6fd1d2b+dirty 2.63 MiB 3.75 MiB 1.12 MiB
8d251c2+dirty 2.63 MiB 3.69 MiB 1.05 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.69 ms 429.83 ms 12.14 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b677956+dirty 378.37 ms 368.50 ms -9.87 ms
d16beca+dirty 389.49 ms 423.86 ms 34.37 ms
7f6950b+dirty 432.72 ms 476.91 ms 44.19 ms
9282172+dirty 363.57 ms 399.78 ms 36.20 ms
8f0282e+dirty 706.47 ms 749.07 ms 42.60 ms
e5bc97b+dirty 409.10 ms 471.61 ms 62.51 ms
5fe8312+dirty 389.98 ms 421.46 ms 31.48 ms
5e5c392+dirty 360.23 ms 347.88 ms -12.35 ms
3ffcddd+dirty 244.82 ms 295.47 ms 50.65 ms
ed3d77e+dirty 366.04 ms 411.33 ms 45.28 ms

App size

Revision Plain With Sentry Diff
b677956+dirty 7.15 MiB 8.39 MiB 1.23 MiB
d16beca+dirty 7.15 MiB 8.37 MiB 1.22 MiB
7f6950b+dirty 7.15 MiB 8.37 MiB 1.22 MiB
9282172+dirty 7.15 MiB 8.37 MiB 1.22 MiB
8f0282e+dirty 7.15 MiB 8.40 MiB 1.24 MiB
e5bc97b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
5fe8312+dirty 7.15 MiB 8.38 MiB 1.23 MiB
5e5c392+dirty 7.15 MiB 8.39 MiB 1.23 MiB
3ffcddd+dirty 7.15 MiB 8.04 MiB 912.17 KiB
ed3d77e+dirty 7.15 MiB 8.35 MiB 1.21 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.88 ms 1211.02 ms -6.85 ms
Size 3.19 MiB 4.35 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f32b22a+dirty 1238.83 ms 1249.28 ms 10.45 ms
205982c+dirty 1228.06 ms 1237.72 ms 9.66 ms
d053743+dirty 1223.18 ms 1214.25 ms -8.93 ms
8b6825a+dirty 1210.41 ms 1199.10 ms -11.31 ms
27ef4ee+dirty 1236.41 ms 1244.90 ms 8.49 ms
0eacc98+dirty 1223.85 ms 1233.12 ms 9.27 ms
30189be+dirty 1228.73 ms 1219.06 ms -9.67 ms
87dd218+dirty 1213.55 ms 1221.57 ms 8.02 ms
6fd1d2b+dirty 1230.85 ms 1230.13 ms -0.72 ms
8d251c2+dirty 1221.19 ms 1227.12 ms 5.93 ms

App size

Revision Plain With Sentry Diff
f32b22a+dirty 3.19 MiB 4.33 MiB 1.14 MiB
205982c+dirty 2.92 MiB 3.67 MiB 772.63 KiB
d053743+dirty 3.19 MiB 4.32 MiB 1.13 MiB
8b6825a+dirty 3.19 MiB 4.32 MiB 1.13 MiB
27ef4ee+dirty 2.92 MiB 3.41 MiB 503.72 KiB
0eacc98+dirty 3.19 MiB 4.25 MiB 1.07 MiB
30189be+dirty 3.19 MiB 4.26 MiB 1.08 MiB
87dd218+dirty 3.19 MiB 4.33 MiB 1.14 MiB
6fd1d2b+dirty 3.19 MiB 4.32 MiB 1.13 MiB
8d251c2+dirty 3.19 MiB 4.25 MiB 1.06 MiB

@lucas-zimerman
Copy link
Collaborator

Were the e2e tests passing before? it seems like it's not finding the Android emulators

@antonis
Copy link
Contributor

antonis commented Apr 17, 2025

Were the e2e tests passing before? it seems like it's not finding the Android emulators

The iOS 0.79.1 E2E tests also fail. I think it is related with the RN bump since the tests are 🟢 on main. I've also tried with the latest Maestro but the result was the same 🤔

@krystofwoldrich krystofwoldrich marked this pull request as draft April 29, 2025 12:07
@krystofwoldrich
Copy link
Contributor Author

I'll look into it.

@krystofwoldrich krystofwoldrich force-pushed the bump-e2e-tests-rn-version branch from ae7d563 to 7d8c80f Compare April 29, 2025 15:48
@krystofwoldrich
Copy link
Contributor Author

The default template changes, I've adjusted our script to fit better to all versions of the template over the supported version.

7d8c80f (#4759)

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

The default template changes, I've adjusted our script to fit better to all versions of the template over the supported version.

Thank you 🙇

@krystofwoldrich krystofwoldrich marked this pull request as ready for review April 30, 2025 09:18
@krystofwoldrich krystofwoldrich merged commit f880983 into main Apr 30, 2025
77 checks passed
@krystofwoldrich krystofwoldrich deleted the bump-e2e-tests-rn-version branch April 30, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants