-
-
Notifications
You must be signed in to change notification settings - Fork 355
chore(samples): Add eas-update-configure script #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
| 7bc4d75 | 488.76 ms | 473.28 ms | -15.48 ms |
| 13f280b | 486.16 ms | 472.45 ms | -13.71 ms |
| c314a21 | 446.24 ms | 439.98 ms | -6.26 ms |
| 3ffcddd | 302.92 ms | 315.80 ms | 12.88 ms |
| 2ec71da | 438.14 ms | 460.46 ms | 22.32 ms |
| 498d77a | 422.28 ms | 419.10 ms | -3.18 ms |
| 0d3e677 | 422.82 ms | 411.90 ms | -10.92 ms |
| c4bd70f | 438.35 ms | 442.18 ms | 3.84 ms |
| b6f8ea2 | 472.49 ms | 469.60 ms | -2.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
| 7bc4d75 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 13f280b | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| c314a21 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 3ffcddd | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 2ec71da | 17.73 MiB | 20.10 MiB | 2.37 MiB |
| 498d77a | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| 0d3e677 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| c4bd70f | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| b6f8ea2 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 1228.04 ms | 1237.20 ms | 9.16 ms |
| 457e29f+dirty | 1253.94 ms | 1269.18 ms | 15.24 ms |
| 4297324+dirty | 1230.27 ms | 1232.53 ms | 2.27 ms |
| 2f9e699+dirty | 1212.55 ms | 1232.67 ms | 20.12 ms |
| a18210a+dirty | 1237.15 ms | 1224.85 ms | -12.29 ms |
| 73fc872+dirty | 1236.16 ms | 1237.15 ms | 0.99 ms |
| 12427f4+dirty | 1267.15 ms | 1271.30 ms | 4.15 ms |
| 025d490+dirty | 1237.51 ms | 1238.34 ms | 0.83 ms |
| 05b43ab+dirty | 1225.33 ms | 1227.33 ms | 2.00 ms |
| e1b1c86+dirty | 1229.55 ms | 1233.92 ms | 4.37 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 2.36 MiB | 3.10 MiB | 759.43 KiB |
| 457e29f+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
| 4297324+dirty | 2.36 MiB | 3.08 MiB | 735.61 KiB |
| 2f9e699+dirty | 2.63 MiB | 3.78 MiB | 1.14 MiB |
| a18210a+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| 73fc872+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| 12427f4+dirty | 2.36 MiB | 2.88 MiB | 530.38 KiB |
| 025d490+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 05b43ab+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| e1b1c86+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 1235.66 ms | 1223.78 ms | -11.88 ms |
| 457e29f+dirty | 1256.71 ms | 1258.50 ms | 1.79 ms |
| 4297324+dirty | 1240.86 ms | 1232.04 ms | -8.81 ms |
| 2f9e699+dirty | 1217.79 ms | 1221.47 ms | 3.68 ms |
| a18210a+dirty | 1218.06 ms | 1215.49 ms | -2.57 ms |
| 73fc872+dirty | 1235.27 ms | 1228.18 ms | -7.08 ms |
| 12427f4+dirty | 1224.90 ms | 1231.40 ms | 6.50 ms |
| 025d490+dirty | 1205.27 ms | 1206.15 ms | 0.88 ms |
| 05b43ab+dirty | 1231.12 ms | 1235.83 ms | 4.70 ms |
| e1b1c86+dirty | 1225.59 ms | 1228.36 ms | 2.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 2.92 MiB | 3.67 MiB | 772.00 KiB |
| 457e29f+dirty | 2.92 MiB | 3.43 MiB | 524.75 KiB |
| 4297324+dirty | 2.92 MiB | 3.64 MiB | 741.22 KiB |
| 2f9e699+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| a18210a+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| 73fc872+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| 12427f4+dirty | 2.92 MiB | 3.44 MiB | 533.29 KiB |
| 025d490+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 05b43ab+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
| e1b1c86+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0c32605+dirty | 404.08 ms | 412.82 ms | 8.73 ms |
| 205982c+dirty | 383.94 ms | 424.98 ms | 41.04 ms |
| e4d9fe0+dirty | 368.38 ms | 415.44 ms | 47.05 ms |
| fe13591+dirty | 539.51 ms | 597.92 ms | 58.40 ms |
| cc8a6ca+dirty | 397.63 ms | 393.60 ms | -4.03 ms |
| 75774ea+dirty | 426.80 ms | 455.43 ms | 28.62 ms |
| 79976dd+dirty | 373.25 ms | 404.64 ms | 31.39 ms |
| e5c9b8b+dirty | 335.40 ms | 360.06 ms | 24.67 ms |
| 2501f36+dirty | 403.27 ms | 427.94 ms | 24.67 ms |
| 8f0282e+dirty | 706.47 ms | 749.07 ms | 42.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0c32605+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 205982c+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| e4d9fe0+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| fe13591+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| cc8a6ca+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 75774ea+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
| 79976dd+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| e5c9b8b+dirty | 7.15 MiB | 8.10 MiB | 980.41 KiB |
| 2501f36+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 8f0282e+dirty | 7.15 MiB | 8.40 MiB | 1.24 MiB |
| } | ||
| "eas": {} | ||
| }, | ||
| "owner": "__OWNER__", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we hide this file and create a new one that is git ignored so we can easily test with eas builds?
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and the scripts worked as expected for me 🎉
Adds a simple script for quick access to configuring EAS Update.
#skip-changelog