feat(replay): Add beforeErrorSampling callback to mobileReplayIntegration #5393

antonis · 2025-11-20T15:55:00Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Add support for filtering replay captures on errors through a new beforeErrorSampling callback in mobileReplayIntegration. This allows developers to control which errors should trigger replay capture, similar to the JavaScript SDK's beforeErrorSampling implementation (see https://docs.sentry.io/platforms/javascript/session-replay/understanding-sessions/#ignore-certain-errors-for-error-sampling)

💡 Motivation and Context

Fixes #5392

Docs PR: getsentry/sentry-docs#15583

💚 How did you test it?

Manually, Unit tests

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

…tion

github-actions · 2025-11-20T15:55:40Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8c195b6

antonis · 2025-11-20T15:59:34Z

@sentry review

packages/core/src/js/replay/mobilereplay.ts

packages/core/test/replay/mobilereplay.test.ts

github-actions · 2025-11-20T16:40:15Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	391.84 ms	424.22 ms	32.38 ms
Size	43.94 MiB	48.87 MiB	4.93 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`161947d`+dirty	349.27 ms	435.09 ms	85.82 ms
`652f785`+dirty	367.80 ms	390.71 ms	22.91 ms
`8d89cc9`+dirty	357.69 ms	415.79 ms	58.10 ms
`c771b48`+dirty	382.10 ms	409.02 ms	26.92 ms
`459a438`+dirty	359.50 ms	390.53 ms	31.03 ms
`e07935d`+dirty	380.10 ms	377.48 ms	-2.62 ms
`b7aa1aa`+dirty	281.02 ms	317.53 ms	36.51 ms
`0d6e618`+dirty	369.02 ms	387.69 ms	18.67 ms
`c08359e`+dirty	406.04 ms	428.87 ms	22.83 ms
`526494a`+dirty	361.10 ms	410.84 ms	49.74 ms

App size

Revision	Plain	With Sentry	Diff
`161947d`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`652f785`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`8d89cc9`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c771b48`+dirty	43.94 MiB	48.85 MiB	4.91 MiB
`459a438`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`e07935d`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`b7aa1aa`+dirty	7.15 MiB	8.46 MiB	1.31 MiB
`0d6e618`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`c08359e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`526494a`+dirty	43.94 MiB	48.82 MiB	4.88 MiB

github-actions · 2025-11-20T16:40:20Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	427.40 ms	450.92 ms	23.52 ms
Size	43.75 MiB	48.04 MiB	4.29 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`77061ed`+dirty	369.55 ms	408.35 ms	38.80 ms
`59f3a84`+dirty	382.16 ms	376.45 ms	-5.71 ms
`46da307`	455.92 ms	443.79 ms	-12.13 ms
`652f785`+dirty	401.02 ms	420.60 ms	19.58 ms
`1bea095`+dirty	401.42 ms	426.93 ms	25.52 ms
`c771b48`+dirty	412.79 ms	431.96 ms	19.17 ms
`e07935d`+dirty	448.82 ms	489.10 ms	40.29 ms
`90afdd3`+dirty	375.94 ms	377.52 ms	1.58 ms
`b7aa1aa`+dirty	324.73 ms	327.76 ms	3.03 ms
`0d6e618`+dirty	414.00 ms	416.90 ms	2.90 ms

App size

Revision	Plain	With Sentry	Diff
`77061ed`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`59f3a84`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`46da307`	17.75 MiB	19.68 MiB	1.93 MiB
`652f785`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`1bea095`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`c771b48`+dirty	43.75 MiB	48.02 MiB	4.27 MiB
`e07935d`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`90afdd3`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`b7aa1aa`+dirty	17.75 MiB	19.75 MiB	2.00 MiB
`0d6e618`+dirty	43.75 MiB	47.99 MiB	4.24 MiB

github-actions · 2025-11-20T16:46:38Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1217.72 ms	1219.00 ms	1.28 ms
Size	3.41 MiB	4.59 MiB	1.18 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e07935d`+dirty	1217.37 ms	1211.44 ms	-5.93 ms
`534ba8c`+dirty	1230.22 ms	1231.18 ms	0.96 ms
`ec14be7`+dirty	1234.64 ms	1245.54 ms	10.90 ms
`98f632c`+dirty	1236.40 ms	1241.62 ms	5.22 ms
`266bc7e`+dirty	1190.56 ms	1191.47 ms	0.91 ms
`bc9680d`+dirty	1221.41 ms	1241.47 ms	20.06 ms
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`7091004`+dirty	1215.54 ms	1215.58 ms	0.04 ms
`bfe454a`+dirty	1235.33 ms	1243.12 ms	7.79 ms
`73f2455`+dirty	1213.49 ms	1211.96 ms	-1.53 ms

App size

Revision	Plain	With Sentry	Diff
`e07935d`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`534ba8c`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`ec14be7`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`98f632c`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`266bc7e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`bc9680d`+dirty	2.63 MiB	3.81 MiB	1.18 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`7091004`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`bfe454a`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`73f2455`+dirty	3.41 MiB	4.58 MiB	1.17 MiB

github-actions · 2025-11-20T16:52:33Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1217.31 ms	1217.89 ms	0.57 ms
Size	3.41 MiB	4.59 MiB	1.18 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e07935d`+dirty	1225.85 ms	1227.72 ms	1.87 ms
`534ba8c`+dirty	1225.00 ms	1237.43 ms	12.43 ms
`ec14be7`+dirty	1229.62 ms	1230.53 ms	0.91 ms
`98f632c`+dirty	1221.38 ms	1229.26 ms	7.88 ms
`266bc7e`+dirty	1217.73 ms	1222.30 ms	4.57 ms
`bc9680d`+dirty	1228.57 ms	1233.64 ms	5.07 ms
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`7091004`+dirty	1219.11 ms	1225.98 ms	6.87 ms
`bfe454a`+dirty	1231.82 ms	1239.98 ms	8.16 ms
`73f2455`+dirty	1219.85 ms	1218.29 ms	-1.56 ms

App size

Revision	Plain	With Sentry	Diff
`e07935d`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`534ba8c`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`ec14be7`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`98f632c`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`266bc7e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`bc9680d`+dirty	3.19 MiB	4.38 MiB	1.19 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`7091004`+dirty	3.41 MiB	4.57 MiB	1.16 MiB
`bfe454a`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`73f2455`+dirty	3.41 MiB	4.58 MiB	1.17 MiB

lucas-zimerman · 2025-11-21T13:12:19Z

packages/core/src/js/replay/mobilereplay.ts

+      try {
+        if (initOptions.beforeErrorSampling(event, hint) === false) {
+          debug.log(
+            `[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} skipped due to beforeErrorSampling for event ${event.event_id}.`,


You did a great naming log! But I think using skipped may give the impression that the replay will not be sent afterward, what do you think of the following suggestion?

Suggested change

`[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} skipped due to beforeErrorSampling for event ${event.event_id}.`,

`[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} not sent; beforeErrorSampling conditions not met for event ${event.event_id}.`,

lucas-zimerman

left a suggestion for the log phrase, but other than that, LGTM!

feat(replay): Add beforeErrorSampling callback to mobileReplayIntegra…

57c34f6

…tion

Adds changelog

1632659

sentry bot reviewed Nov 20, 2025

View reviewed changes

packages/core/src/js/replay/mobilereplay.ts Show resolved Hide resolved

packages/core/test/replay/mobilereplay.test.ts Show resolved Hide resolved

Add exception handling

9eac259

antonis added the ready-to-merge Triggers the full CI test suite label Nov 20, 2025

antonis mentioned this pull request Nov 20, 2025

RN: Add beforeErrorSampling callback to mobileReplayIntegration getsentry/sentry-docs#15583

Open

6 tasks

Merge branch 'main' into antonis/replay-beforeErrorSampling

8c195b6

antonis marked this pull request as ready for review November 20, 2025 16:24

antonis requested review from alwx and lucas-zimerman as code owners November 20, 2025 16:24

antonis mentioned this pull request Nov 20, 2025

Allow beforeErrorSampling on mobileReplayIntegration #5392

Open

lucas-zimerman reviewed Nov 21, 2025

View reviewed changes

lucas-zimerman approved these changes Nov 21, 2025

View reviewed changes

	`[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} skipped due to beforeErrorSampling for event ${event.event_id}.`,
	`[Sentry] ${MOBILE_REPLAY_INTEGRATION_NAME} not sent; beforeErrorSampling conditions not met for event ${event.event_id}.`,

Uh oh!

feat(replay): Add beforeErrorSampling callback to mobileReplayIntegration #5393

Are you sure you want to change the base?

feat(replay): Add beforeErrorSampling callback to mobileReplayIntegration #5393

Uh oh!

Conversation

antonis commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonis commented Nov 20, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2025

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Nov 20, 2025

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Nov 20, 2025

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Nov 20, 2025

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading