Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check restricted names case insensitive #18

Merged
merged 2 commits into from
Jun 11, 2021
Merged

fix: Check restricted names case insensitive #18

merged 2 commits into from
Jun 11, 2021

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jun 8, 2021 •
edited
Loading

Applies case insensitive checks for restricted release and environment names, following the logic in getsentry/relay#479.

@jan-auer jan-auer requested review from mitsuhiko and ahmedetefy June 11, 2021 06:32
ahmedetefy
ahmedetefy approved these changes Jun 11, 2021
View reviewed changes
Copy link

@ahmedetefy ahmedetefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-auer jan-auer merged commit 041537a into master Jun 11, 2021
@jan-auer jan-auer deleted the fix/ignore-ascii-case branch June 11, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedetefy ahmedetefy ahmedetefy approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @ahmedetefy