Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-releases clobbering stable releases #27

Open
rhcarvalho opened this issue Jul 22, 2020 · 2 comments · Fixed by #29
Open

Pre-releases clobbering stable releases #27

rhcarvalho opened this issue Jul 22, 2020 · 2 comments · Fixed by #29

Comments

@rhcarvalho
Copy link
Contributor

@philipphofmann was trying to release sentry-cocoa 5.1.10 after 5.1.10-beta.0 had been released.
craft fails because a file 5.1.10.json already exists.

image

While there is a fix to be made in craft, a question that is relevant for the registry is whether pre-release versions should generate symlinks in the same way as regular releases.

version_info = VersionInfo.parse(base.rsplit('.', 1)[0])
with open(path) as f:
if version_info != VersionInfo.parse(json.load(f)['version']):
error('Filename does not match version (%s)' % path)
target_files = [
'%s.json' % version_info.major,
'%s.%s.json' % (version_info.major, version_info.minor),
'%s.%s.%s.json' % (version_info.major, version_info.minor, version_info.patch),
'latest.json',
]

For the purposes for what the registry is used, when 5.1.10-beta.0 is released, is it correct to make 5.json, 5.1.json, 5.1.10.json and latest.json all point to the pre-release version file 5.1.10-beta.0.json?

@untitaker
Copy link
Member

pre-releases should not be in the release registry at all imo

@rhcarvalho
Copy link
Contributor Author

Re-opening because #29 only prevents pre-releases from creating x.y.z.json, but doesn't cover pre-releases overwriting x.json, x.y.json and latest.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants