fix: Do not generate symlinks for major.minor.patch #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those version files are meant to be regular files and not symlinks. Pre-release versions such as 5.1.10-beta.0 should not create a symlink 5.1.10.json, because that file name should be reserved for the actual 5.1.10 release. At the moment, craft refuses to publish a new release because the registry already contains a version file for the release being published. Note that the files under packages/nuget/ being removed refer to version numbers that have never been released (they do not exist in Nuget, only the preview versions exist).
untitaker
approved these changes
Jul 22, 2020
tonyo
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those version files are meant to be regular files and not symlinks.
Pre-release versions such as
5.1.10-beta.0should not create a symlink5.1.10.json, because that file name should be reserved for the actual5.1.10release.At the moment, craft refuses to publish a new release because the registry already contains a version file for the release being published.
Note that the files under packages/nuget/ being removed refer to version numbers that have never been released (they do not exist in Nuget, only the preview versions exist).
Fixes #27.
See #26, @philipphofmann had to manually delete the
packages/cocoapods/sentry-cocoa/5.1.10.jsonsymlink and update files outside ofcraft.