-
-
Notifications
You must be signed in to change notification settings - Fork 505
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Re-position CaptureExceptions middleware
When `CaptureExceptions` is the first middleware, the benefits are: 1. It captures as many exceptions as possible. 2. Transactions can record almost the full length of the request's events. But there are also some downsides: 1. Exceptions of the outter middlewares may mostly be noise to users, as they usually are the Rails default. 2. It makes skipping some requests' transactions very hard. For example: #1404 By re-positioning the middleware after `ActionDispatch::Executor`, we can automatically avoid the downsides while still keeping most of the benefits. It also allows us to remove the patch on `FileHandler`.
- Loading branch information
Showing
4 changed files
with
10 additions
and
28 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters