Add Metrics.duration_(start,end)

getsentry · Dec 19, 2024 · fda0638 · fda0638
1 parent bb9ce72
commit fda0638
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb b/sentry-ruby/lib/sentry/cron/monitor_check_ins.rb
@@ -14,12 +14,12 @@ def perform(*args, **opts)
                                                 :in_progress,
                                                 monitor_config: monitor_config)
 
-          start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+          start = Metrics::Timing.duration_start
 
           begin
             # need to do this on ruby <= 2.6 sadly
             ret = method(:perform).super_method.arity == 0 ? super() : super
-            duration = Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
+            duration = Metrics::Timing.duration_end(start)
 
             Sentry.capture_check_in(slug,
                                     :ok,
@@ -29,7 +29,7 @@ def perform(*args, **opts)
 
             ret
           rescue Exception
-            duration = Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
+            duration = Metrics::Timing.duration_end(start)
 
             Sentry.capture_check_in(slug,
                                     :error,

diff --git a/sentry-ruby/lib/sentry/metrics/timing.rb b/sentry-ruby/lib/sentry/metrics/timing.rb
@@ -37,6 +37,14 @@ def day
         def week
           Sentry.utc_now.to_i / (3600.0 * 24.0 * 7.0)
         end
+
+        def duration_start
+          Process.clock_gettime(Process::CLOCK_MONOTONIC)
+        end
+
+        def duration_end(start)
+          Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
+        end
       end
     end
   end

diff --git a/sentry-ruby/spec/sentry/cron/monitor_check_ins_spec.rb b/sentry-ruby/spec/sentry/cron/monitor_check_ins_spec.rb
@@ -123,6 +123,7 @@ def perform(a, b = 42, c: 99)
         expect(ok_event.monitor_slug).to eq('job')
         expect(ok_event.status).to eq(:ok)
         expect(ok_event.monitor_config).to be_nil
+        expect(ok_event.duration).to be > 0
       end
     end
 
@@ -162,6 +163,7 @@ def perform; work end
         expect(ok_event.monitor_slug).to eq('job')
         expect(ok_event.status).to eq(:ok)
         expect(ok_event.monitor_config).to be_nil
+        expect(ok_event.duration).to be > 0
       end
     end