Skip to content

SystemStackError exceptions dropped by payload truncation logic #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sl0thentr0py opened this issue Apr 27, 2022 · 2 comments · Fixed by #1807
Closed

SystemStackError exceptions dropped by payload truncation logic #1799

sl0thentr0py opened this issue Apr 27, 2022 · 2 comments · Fixed by #1807
Assignees

Comments

@sl0thentr0py
Copy link
Member

These exceptions have lots of frames in the exception object, we could be a bit smarter and truncate the frames instead of dropping the whole envelope item.

@PikachuEXE
Copy link
Contributor

Where is the payload truncation logic happening now?
I can try to figure out what to change. (As this is affecting one of my projects)

@sl0thentr0py
Copy link
Member Author

@PikachuEXE here

if result.bytesize > Event::MAX_SERIALIZED_PAYLOAD_SIZE
size_breakdown = item.payload.map do |key, value|
"#{key}: #{JSON.generate(value).bytesize}"
end.join(", ")
log_debug("Envelope item [#{item.type}] is still oversized without breadcrumbs: {#{size_breakdown}}")
next
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment